Skip to content

Fix disable velocity and effort limiting feature - #3425

Merged
bmagyar merged 9 commits into
ros-controls:masterfrom
pal-robotics-forks:fix/disable/effort_limiting
Jul 1, 2026
Merged

Fix disable velocity and effort limiting feature#3425
bmagyar merged 9 commits into
ros-controls:masterfrom
pal-robotics-forks:fix/disable/effort_limiting

Conversation

@saikishor

Copy link
Copy Markdown
Member

Description

When the effort limit is explicitly disabled as follows, the limit enforcement is still happening, this PR fixes that issue

            <command_interface name="effort">
                <limits enable="false"/>
            </command_interface>

Is this user-facing behavior change?

YES, but towards what is expected

Did you use Generative AI?

Docs part eith claude

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Jun 30, 2026
@saikishor
saikishor force-pushed the fix/disable/effort_limiting branch from 57898a5 to f114a86 Compare June 30, 2026 07:49
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.22642% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.46%. Comparing base (d9c0eb4) to head (72cf2b1).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
joint_limits/test/test_joint_range_limiter.cpp 95.58% 0 Missing and 3 partials ⚠️
joint_limits/test/test_joint_soft_limiter.cpp 96.25% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
+ Coverage   89.42%   89.46%   +0.04%     
==========================================
  Files         162      162              
  Lines       21031    21185     +154     
  Branches     1645     1653       +8     
==========================================
+ Hits        18807    18954     +147     
  Misses       1531     1531              
- Partials      693      700       +7     
Flag Coverage Δ
unittests 89.46% <96.22%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
joint_limits/src/joint_limits_helpers.cpp 89.21% <100.00%> (-0.59%) ⬇️
joint_limits/src/joint_soft_limiter.cpp 91.42% <100.00%> (+0.12%) ⬆️
joint_limits/test/test_joint_range_limiter.cpp 99.33% <95.58%> (-0.67%) ⬇️
joint_limits/test/test_joint_soft_limiter.cpp 99.29% <96.25%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread joint_limits/include/joint_limits/joint_limits_helpers.hpp Outdated
@saikishor
saikishor requested a review from bmagyar June 30, 2026 18:23
destogl
destogl previously approved these changes Jun 30, 2026
bmagyar
bmagyar previously approved these changes Jun 30, 2026
@bmagyar
bmagyar dismissed stale reviews from destogl and themself via 3eebf56 June 30, 2026 21:09
@saikishor saikishor changed the title Fix disable effort limiting feature Fix disable velocity and effort limiting feature Jun 30, 2026
@saikishor
saikishor requested review from bmagyar and destogl July 1, 2026 07:06
@bmagyar
bmagyar merged commit ea9700a into ros-controls:master Jul 1, 2026
23 of 28 checks passed
@bmagyar
bmagyar deleted the fix/disable/effort_limiting branch July 1, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants