Mavlink: update MAG_CAL_STATUS failure enums#3750
Open
christianpetri wants to merge 1 commit into
Open
Conversation
Rename BAD_ORIENTATION/BAD_RADIUS to FAILED_ORIENTATION/FAILED_RADIUS and add three new failure codes introduced by the upstream PR: - MAG_CAL_FAILED_OFFSETS (value 8) - MAG_CAL_FAILED_DIAG_SCALING (value 9) - MAG_CAL_FAILED_RESIDUALS_HIGH (value 10) Changes: common.xml + regenerated Mavlink.cs enum block only.
95b2cd2 to
f2a9bcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AP_Compass: report specific failure reason when fit rejected (ardupilot#32757) extended ArduPilot's compass calibrator to emit a specific failure code in MAG_CAL_REPORT.cal_status instead of always returning the generic MAG_CAL_FAILED. Three new status values were added (8 = FAILED_OFFSETS, 9 = FAILED_DIAG_SCALING, 10 = FAILED_RESIDUALS_HIGH).
That required the MAVLink spec and every toolchain downstream of it to be updated:
Changes
No other files are touched.
Verification
dotnet build MissionPlanner.csproj -c Debug succeeds with 0 errors.