Skip to content

Mavlink: update to latest ArduPilot/mavlink#3748

Closed
christianpetri wants to merge 1 commit into
ArduPilot:masterfrom
christianpetri:mavlink-bump-latest-ardupilot-mavlink
Closed

Mavlink: update to latest ArduPilot/mavlink#3748
christianpetri wants to merge 1 commit into
ArduPilot:masterfrom
christianpetri:mavlink-bump-latest-ardupilot-mavlink

Conversation

@christianpetri

@christianpetri christianpetri commented Jul 4, 2026

Copy link
Copy Markdown

Sync MAVLink message definitions from the latest ArduPilot/mavlink and regenerate the Mission Planner MAVLink bindings.

Summary:

Generator fix (ExtLibs/Mavlink/pymavlink/generator/mavgen_cs.py):

  • Also clean newlines/CRs from entry.param[i].description before rendering.
  • Upstream common.xml now contains MAV_CMDs whose <param> text spans multiple lines (e.g. new DO_FIGURE_EIGHT, promoted NAV_ARC_WAYPOINT).
  • The vendored C# generator already ran cleanText on enum/entry descriptions but never on param descriptions, so those newlines landed inside single-line ///<summary> and [Description("...")] strings and broke the C# parser.
  • The same convention (cleanText on all human-readable text) is applied consistently now.

Verification:

  • dotnet build MissionPlanner.csproj -c Debug succeeds with 0 errors (pre-existing warnings unchanged).

Notes:

  • Mechanical bump + minimal 2-line generator fix required to make the regen compile; all changes remain under ExtLibs/Mavlink/, matching prior Mavlink: update commits.
  • Follow-up code/test changes that adopt the new MAG_CAL_FAILED_* enum names will be made in a separate PR.

AI-assisted: prepared with the help of GitHub Copilot (agent mode). All changes were reviewed and locally compiled by the author before submission.

@christianpetri
christianpetri marked this pull request as draft July 4, 2026 09:32
@christianpetri
christianpetri force-pushed the mavlink-bump-latest-ardupilot-mavlink branch from 4106fd6 to 781959a Compare July 4, 2026 09:37
@christianpetri
christianpetri marked this pull request as ready for review July 4, 2026 09:48
@christianpetri
christianpetri force-pushed the mavlink-bump-latest-ardupilot-mavlink branch from 781959a to 45c4a6c Compare July 4, 2026 09:49
@christianpetri

Copy link
Copy Markdown
Author

@peterbarker

@christianpetri
christianpetri force-pushed the mavlink-bump-latest-ardupilot-mavlink branch from 45c4a6c to d6ab7b4 Compare July 11, 2026 16:47
@peterbarker

Copy link
Copy Markdown
Contributor

@christianpetri I'm not a maintainer here.

I would suggest that -11,500 lines / +15,5000 lines is a fair indication of "wrong", however.

@christianpetri

Copy link
Copy Markdown
Author

Closing in favour of #3750, which contains only the minimal change needed: the \MAG_CAL_STATUS\ enum update from mavlink/mavlink#2478 applied to \common.xml\ and the corresponding \Mavlink.cs\ enum block — 2 files, 1 commit.

@christianpetri
christianpetri deleted the mavlink-bump-latest-ardupilot-mavlink branch July 14, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants