Skip to content

handle edge case where key might expire in the middle of the multi exec for redis store#44

Merged
julienwilmet merged 1 commit into
ysocorp:developfrom
jmacpherson:develop
Apr 28, 2022
Merged

handle edge case where key might expire in the middle of the multi exec for redis store#44
julienwilmet merged 1 commit into
ysocorp:developfrom
jmacpherson:develop

Conversation

@jmacpherson

Copy link
Copy Markdown
Contributor

Discussion of the edge case: https://www.bennadel.com/blog/2785-volatile-keys-can-expire-mid-multi-transaction-in-redis-jedis.htm

Evidence of the ability to reprod with this library:
Screen Shot 2022-04-26 at 3 21 07 PM

Comment thread src/RedisStore.js
@julienwilmet

Copy link
Copy Markdown
Contributor

Does this also fix #39 and #44 ?

@jmacpherson

Copy link
Copy Markdown
Contributor Author

Does this also fix #39 and #44 ?

I can't speak to the X-RateLimit-Reset bug mentioned in #39, but it does address the ttl -1 issue, without resetting the counter back to 1 when doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants