fix 2 bugs for redis: ttl -1 and X-RateLimit-Reset#39
Open
codeHui wants to merge 1 commit into
Open
Conversation
1,"dateEnd===-1" may happen just after ttl expires then "await this.client.incrBy(key, weight)" will set ttl to -1; we count this low probability requests as the previous period and check "dateEnd===-1" for the next request 2,add "dateEnd = Date.now() + dateEnd * 1000;" the unit of Date.now() is millisecond
|
I was in the same situation. |
edelache
approved these changes
Mar 3, 2022
edelache
left a comment
edelache
left a comment
There was a problem hiding this comment.
I can confirm, this fixes the two bugs.
|
Looks like #44 fixed the first issue. I was hoping there's a chance of getting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1,"dateEnd===-1" may happen just after ttl expires then "await this.client.incrBy(key, weight)" will set ttl to -1; we count this low probability requests as the previous period and check "dateEnd===-1" for the next request
2,add "dateEnd = Date.now() + dateEnd * 1000;" the unit of Date.now() is millisecond, this affect "X-RateLimit-Reset"
I am happy if I could contribute the code, and any questions is welcome