Skip to content

Restore the origin-bound declaration on DigitalCredential #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcoscaceres wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Restore the origin-bound declaration on DigitalCredential #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,9 @@ <h3>
static boolean userAgentAllowsProtocol(DOMString protocol);
};
</pre>
<p>
{{DigitalCredential}} instances are [=Credential/origin bound=].
</p>
<h4>
The `protocol` member
</h4>
Expand Down Expand Up @@ -1652,9 +1655,6 @@ <h3>
<li>Let |signal| be |options|'s {{CredentialRequestOptions/signal}}, if
present.
</li>
<li>If |origin| is an [=opaque origin=], return [=a promise rejected
with=] a {{"SecurityError"}} {{DOMException}}.
</li>
<li>Let |global| be [=this=]'s [=relevant global object=].
</li>
<li>Let |document| be |global|'s [=associated `Document`=].
Expand Down Expand Up @@ -1712,9 +1712,6 @@ <h3>
<li>If |signal| is [=AbortSignal/aborted=], return [=a promise rejected
with=] |signal|'s [=AbortSignal/abort reason=].
</li>
<li>If |origin| is an [=opaque origin=], return [=a promise rejected
with=] a {{"SecurityError"}} {{DOMException}}.
</li>
<li>Let |global| be [=this=]'s [=relevant global object=].
</li>
<li>Let |document| be |global|'s [=associated `Document`=].
Expand Down Expand Up @@ -1902,15 +1899,6 @@ <h3>
[[[secure-contexts#security-considerations]]] section of the
[[[secure-contexts]]] specification for more information.
</p>
<p>

@mohamedamir mohamedamir Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I feel it make sense to update the algorithm, but we should keep some reference to this threat in the security section.
I would update the original text to reference CredMan instead.
What do you think?
I feel this adds important context to the security threat model.

      <p>
        Additionally, requests from an [=opaque origin=] are rejected. Because
        {{DigitalCredential}} instances are [=Credential/origin bound=], calls to
        request or create digital credentials from an [=opaque origin=] (for
        example, a `data:` document, or a document sandboxed without
        `allow-same-origin`) are rejected by [[[credential-management]]],
        reducing the risk of malicious extraction or spoofing from untrusted
        environments.
      </p>

@marcoscaceres marcoscaceres Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense... will add this back.

Additionally, requests from an [=opaque origin=] are rejected. Calls to
{{DigitalCredential/[[DiscoverFromExternalSource]](origin, options,
sameOriginWithAncestors)}} and {{DigitalCredential/[[Create]](origin,
options, sameOriginWithAncestors)}} from an [=opaque origin=] (for
example, a `data:` document, or a document sandboxed without
`allow-same-origin`) are [=reject|rejected=], reducing the risk of
malicious extraction or spoofing from untrusted environments.
</p>
<p>
The Digital Credentials API reduces [=API flooding=] through two
mechanisms:
Expand Down
Loading