Restore the origin-bound declaration on DigitalCredential - #559
Open
marcoscaceres wants to merge 1 commit into
Open
Restore the origin-bound declaration on DigitalCredential#559marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
This was referenced Jul 20, 2026
…check Reverts #509 to restore the origin-bound declaration on DigitalCredential, and removes the opaque-origin SecurityError check added in #535 (from [[DiscoverFromExternalSource]], [[Create]], and the mitigations note). With DigitalCredential declared origin bound, Credential Management rejects a request for it from an opaque origin (see the companion Credential Management PR), so the per-algorithm check here is redundant. This must not land before the Credential Management change, or opaque origins would briefly not be rejected.
marcoscaceres
force-pushed
the
dc-restore-origin-bound
branch
from
July 20, 2026 07:04
e96e9fd to
0f401d2
Compare
marcoscaceres
marked this pull request as ready for review
July 20, 2026 07:08
timcappalli
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the origin-bound declaration on
DigitalCredential(reverts #509) and removes the opaque-originSecurityErrorcheck added in #535 (from[[DiscoverFromExternalSource]],[[Create]], and the mitigations note).With
DigitalCredentialdeclared origin bound, Credential Management rejects a request for it from an opaque origin (companion PR w3c/webappsec-credential-management#304), so the per-algorithm check here is redundant.Must not merge before w3c/webappsec-credential-management#304, or opaque origins would briefly not be rejected. Part of #560.
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff