SAN-789: harden spec-pin-integrity test against shallow submodule clones - #82
Merged
Merged
Conversation
test_spec_pin_is_on_protocol_main false-negatives in shallow clones (depth 1, as used in the cross-SDK smoke) because the parent chain between origin/main and an older-but-merged pin is absent. Detect shallow repo and unshallow before the merge-base --is-ancestor check so the assertion is reliable at any clone depth. Ref SAN-667 (original spec-pin enforcement). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_spec_pin_is_on_protocol_mainfalse-negatives in shallow submodule clones (depth 1, as used in the cross-SDK smoke test) because the parent chain betweenorigin/mainand an older-but-merged pin is absent, causingmerge-base --is-ancestorto return a false negativegit rev-parse --is-shallow-repositoryand unshallow viagit fetch --unshallow originbefore the reachability check, making the assertion reliable at any clone depthRef SAN-667 (original spec-pin enforcement). Parallel fix in sanna-ts.
Test plan
tests/test_spec_pin_integrity.py-- 2 passedgenerate_state_doc.py --check-- up to dateKnown broken baseline
None.
Tickets
SAN-789, SAN-667