Remove the extra xacro path substitution#1120
Open
adminlip wants to merge 1 commit into
Open
Conversation
github-actions
Bot
requested review from
Juliaj,
MarqRazz,
Maverobot,
christophfroehlich and
homalozoa
Contributor
|
This pull request is in conflict. Could you fix it @adminlip? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unnecessary
PathJoinSubstitutionwrapper aroundFindExecutable(name="xacro")in the launch file referenced by #1118. The launch file still passes the xacro executable into the existingCommandsubstitution, but no longer treats that executable lookup as a path-join operation. Verified withpython3 -m compileall -q example_7/bringup/launch/send_trajectory.launch.pyandgit diff --check.