Add launch_ros2_control launch extension#3122
Open
SuperJappie08 wants to merge 2 commits into
Open
Conversation
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
github-actions
Bot
requested review from
MarqRazz,
Maverobot,
bmagyar,
homalozoa and
mhubii
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3122 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 158 158
Lines 19390 19390
Branches 1573 1573
=======================================
Hits 17324 17324
Misses 1419 1419
Partials 647 647
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This was referenced Mar 13, 2026
Contributor
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
Contributor
Author
|
bump to keep alive |
bmagyar
reviewed
May 18, 2026
| @@ -0,0 +1,23 @@ | |||
| # Copyright 2015 Open Source Robotics Foundation, Inc. | |||
Member
There was a problem hiding this comment.
we don't do non-test tests in this organization but use pre-commit instead ;)
please only leave functional tests
bmagyar
reviewed
May 18, 2026
Comment on lines
+8
to
+12
| <maintainer email="36795178+SuperJappie08@users.noreply.github.com">Jasper van Brakel</maintainer> | ||
|
|
||
| <license>Apache-2.0</license> | ||
|
|
||
| <author email="36795178+SuperJappie08@users.noreply.github.com">Jasper van Brakel</author> |
bmagyar
reviewed
May 18, 2026
Comment on lines
+18
to
+20
| <test_depend>ament_copyright</test_depend> | ||
| <test_depend>ament_pep257</test_depend> | ||
| <test_depend>ament_xmllint</test_depend> |
Member
There was a problem hiding this comment.
Suggested change
| <test_depend>ament_copyright</test_depend> | |
| <test_depend>ament_pep257</test_depend> | |
| <test_depend>ament_xmllint</test_depend> |
bmagyar
reviewed
May 18, 2026
| This packages provides a launch action for spawning controllers. | ||
| It is compatible with Humble, Jazzy, Kilted and Rolling. | ||
|
|
||
| Examples for the <i title="XML, YAML, and Python">3 major launch file types</i>, can be found in the [examples folder](examples/). |
Member
There was a problem hiding this comment.
the examples seem to be missing from the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
launch_ros2_controllaunch extension.Related Issues
#2454
Additional Information
This does use the
--controllerspecific argument setup, when I wrote this extention initially.