Skip to content

Add exceptions for non double export from controllers #2904

Draft
saikishor wants to merge 2 commits into
ros-controls:masterfrom
pal-robotics-forks:add/exception/non-double-export
Draft

Add exceptions for non double export from controllers #2904
saikishor wants to merge 2 commits into
ros-controls:masterfrom
pal-robotics-forks:add/exception/non-double-export

Conversation

@saikishor

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Dec 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.45%. Comparing base (eaee0da) to head (c8d694b).
⚠️ Report is 89 commits behind head on master.

Files with missing lines Patch % Lines
...r_interface/src/chainable_controller_interface.cpp 0.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2904      +/-   ##
==========================================
- Coverage   89.50%   89.45%   -0.05%     
==========================================
  Files         155      155              
  Lines       18534    18555      +21     
  Branches     1489     1491       +2     
==========================================
+ Hits        16588    16598      +10     
- Misses       1346     1354       +8     
- Partials      600      603       +3     
Flag Coverage Δ
unittests 89.45% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r_interface/src/chainable_controller_interface.cpp 54.46% <0.00%> (-4.19%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FMT_COMPILE(
"The data type of the interface '{}' ({}) is not of type 'double'. "
"Unfortunately, only 'double' data type is supported for state interfaces. "
"No state interface will be exported. Please correct and recompile the controller "

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please also put some documentation on this onto an issue and reference that in these messages? that way people in the future will be able to follow up on where we stand on it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that

@saikishor saikishor marked this pull request as draft December 18, 2025 17:45
@github-actions

github-actions Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label Feb 2, 2026
@christophfroehlich christophfroehlich moved this to Needs discussion in Review triage Feb 3, 2026
@github-actions github-actions Bot removed the stale label Feb 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added stale and removed stale labels Mar 23, 2026
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added stale and removed stale labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs discussion

Development

Successfully merging this pull request may close these issues.

3 participants