Skip to content

Add tooltips to SD and PF mod settings #37969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndiTafel wants to merge 4 commits into
base: master
Choose a base branch
from
+2 −2
Open

Add tooltips to SD and PF mod settings #37969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0aea06
Update OsuModSuddenDeath.cs
AndiTafel Jun 2, 2026
75c821e
Update ManiaModPerfect.cs
AndiTafel Jun 2, 2026
1c99c93
Merge branch 'master' into master
AndiTafel Jun 5, 2026
d882a43
Merge branch 'master' into master
AndiTafel Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Mania/Mods/ManiaModPerfect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace osu.Game.Rulesets.Mania.Mods
{
public class ManiaModPerfect : ModPerfect
{
[SettingSource("Require perfect hits")]
[SettingSource("Require perfect hits", "Also fail when getting a GREAT hit.")]
public BindableBool RequirePerfectHits { get; } = new BindableBool();

protected override bool FailCondition(HealthProcessor healthProcessor, JudgementResult result)
Expand Down
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Osu/Mods/OsuModSuddenDeath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class OsuModSuddenDeath : ModSuddenDeath
typeof(OsuModTargetPractice),
}).ToArray();

[SettingSource("Also fail when missing a slider tail")]
[SettingSource("Require perfect combo", "Also fail when missing a slider tail.")]

@bdach bdach Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncertain whether this is better than master.

@AndiTafel AndiTafel Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion this makes sense because it's more consistent with Require perfect hits and "perfect combo" is well-known terminology.

But of course it's just a suggestion.

@Joehuu Joehuu Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it "perfect full combo"? It's documented in https://osu.ppy.sh/wiki/en/Gameplay/Full_combo.

@AndiTafel AndiTafel Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, you're right. I was thinking "perfect combo" because lazer displays them as something like 1000/1000 PERFECT on the result screen.
But then I guess Require perfect full combo works.

public BindableBool FailOnSliderTail { get; } = new BindableBool();

protected override bool FailCondition(HealthProcessor healthProcessor, JudgementResult result)
Expand Down
Loading