Add tooltips to SD and PF mod settings#37969
Open
AndiTafel wants to merge 4 commits into
Open
Conversation
Rename mod setting and add tooltip
Add tooltip to mod setting
bdach
added
area:mods
subjective
bdach
reviewed
Jun 9, 2026
| }).ToArray(); | ||
|
|
||
| [SettingSource("Also fail when missing a slider tail")] | ||
| [SettingSource("Require perfect combo", "Also fail when missing a slider tail.")] |
Collaborator
There was a problem hiding this comment.
Uncertain whether this is better than master.
Author
There was a problem hiding this comment.
In my opinion this makes sense because it's more consistent with Require perfect hits and "perfect combo" is well-known terminology.
But of course it's just a suggestion.
Member
There was a problem hiding this comment.
Isn't it "perfect full combo"? It's documented in https://osu.ppy.sh/wiki/en/Gameplay/Full_combo.
Author
There was a problem hiding this comment.
Oh yeah, you're right. I was thinking "perfect combo" because lazer displays them as something like 1000/1000 PERFECT on the result screen.
But then I guess Require perfect full combo works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PF mod setting
Require perfect hits(osu!mania) is currently missing a tooltip, so I added one.The SD mod setting
Also fail when missing a slider tail(osu!) is also missing one and in my opinion its name sounds more like a tooltip, so my suggestion is renaming this mod setting toRequire perfect combo.