Skip to content

Avoid walking all entries to find latest #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
WhyNotHugo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Avoid walking all entries to find latest #566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions recorder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,26 +709,27 @@ unsigned char *decrypt(struct udata *ud, char *topic, char *p64, char *username,
static bool is_newer_than_last(JsonNode *json)
{
bool is_newer = true;
JsonNode *last_array;
JsonNode *fields = json_mkarray();
json_append_element(fields, json_mkstring("tst"));
JsonNode *usernode = json_find_member(json, "username");
JsonNode *devicenode = json_find_member(json, "device");
if (usernode != NULL && devicenode != NULL) {
if ((last_array = last_users(usernode->string_, devicenode->string_, fields)) != NULL) {
JsonNode *lastrec = json_first_child(last_array);
if (lastrec != NULL) {
JsonNode *tst = json_find_member(lastrec, "tst");
if (tst != NULL) {
double last = number(lastrec, "tst");
double current = number(json, "tst");
is_newer = last < current;
}
}
json_delete(last_array);

if (usernode != NULL && devicenode != NULL &&
usernode->tag == JSON_STRING && devicenode->tag == JSON_STRING) {
JsonNode *last_json = json_mkobject();
char path[BUFSIZ];

snprintf(path, sizeof(path), "%s/last/%s/%s/%s-%s.json",
STORAGEDIR, usernode->string_, devicenode->string_,
usernode->string_, devicenode->string_);

if (json_copy_from_file(last_json, path) == TRUE) {
double last = number(last_json, "tst");
double current = number(json, "tst");

if (!isnan(last) && !isnan(current))
is_newer = last < current;
}
json_delete(last_json);
}
json_delete(fields);
return is_newer;
}

Expand Down