Avoid walking all entries to find latest#566
Draft
WhyNotHugo wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Draft because this needs further testing, and I'd prefer to hear if I'm missing any edge cases here. |
Finding the latest entry walks though the whole directory tree seeking the exact matching entry. However, the filename of the entry that should match is predictable. Instead of walking through all entries to find the latest matching one, open the exact expected file. References: owntracks#565
WhyNotHugo
force-pushed
the
simpler-is_newer_than_last
branch
from
b6f9200 to
8652f0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding the latest entry walks though the whole directory tree seeking the exact matching entry. However, the filename of the entry that should match is predictable.
Instead of walking through all entries to find the latest matching one, open the exact expected file.
References: #565