Skip to content

fix(posix): make warmupSpaceRootCache errors non-fatal #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flash7777 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(posix): make warmupSpaceRootCache errors non-fatal #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/storage/fs/posix/tree/tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func New(lu node.PathLookup, bs node.Blobstore, um usermapper.Mapper, trashbin *
// warmup the cache for all space roots right away so clients and migrations don't get confused when starting with a cold cache
err := t.warmupSpaceRootCache(o)
if err != nil {
return nil, errors.Wrap(err, "error warming up space root cache")
t.log.Error().Err(err).Msg("error warming up space root cache, continuing")
}

// scan the whole tree asynchronously to pick up new nodes
Expand Down Expand Up @@ -235,7 +235,7 @@ func (t *Tree) warmupSpaceRootCache(options *options.Options) error {
}
err = t.idCache.Set(context.TODO(), spaceID, spaceID, path)
if err != nil {
return errors.Wrap(err, "could not cache space root path")
t.log.Error().Err(err).Str("spaceID", spaceID).Str("path", path).Msg("could not cache space root path, continuing")
}
}
return nil
Expand Down