fix(posix): make warmupSpaceRootCache errors non-fatal#678
Open
flash7777 wants to merge 1 commit into
Open
Conversation
The warmupSpaceRootCache function runs synchronously during tree initialization. If the NATS KV cache is temporarily unavailable (e.g. during upgrades or migrations), the hard error abort prevents the storage-users service from starting entirely, which cascades into proxy startup failures (502). Change both the cache write error and the caller to log-and-continue instead of aborting. The subsequent async WarmupIDCache will retry and fill in any missing entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warmupSpaceRootCacheerrors non-fatal during tree initializationWarmupIDCachewill retry and fill in any missing entriesProblem
Since commits 0ae322f and c5a3bca,
warmupSpaceRootCacheruns synchronously duringtree.New()and aborts on cache write errors. During upgrades (e.g. 5.x → 7.x) the NATS KV store may be temporarily unavailable, causing the storage-users service to fail startup entirely. This cascades: proxy never binds its port → 502 for all requests.Changes
Two lines changed in
pkg/storage/fs/posix/tree/tree.go:return nil, errors.Wrap(...)→t.log.Error()...(log and continue)return errors.Wrap(...)→t.log.Error()...(log and continue per space)Test plan