Skip to content

fix: await closing the AT port #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boundlesscalm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: await closing the AT port #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/common/sendATCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default async (
) => {
let serialPort: {
sendCommand: (cmd: string) => Promise<string>;
unregister: () => void;
unregister: () => Promise<void>;
};

const createdSerialPort = await createSerialPort(
Expand Down Expand Up @@ -115,18 +115,16 @@ export default async (
);
serialPort = {
sendCommand: (cmd: string) => sendCommandShellMode(sp, cmd),
unregister: () => {
unregister: async () => {
sp.unregister();
createdSerialPort.close();
await createdSerialPort.close();
},
};
} else {
serialPort = {
sendCommand: (cmd: string) =>
sendCommandLineMode(createdSerialPort, cmd),
unregister: () => {
createdSerialPort.close();
},
unregister: () => createdSerialPort.close(),
};
}

Expand All @@ -149,9 +147,10 @@ export default async (
await reducedPromise;
} catch {
serialPort.unregister();
await serialPort.unregister();
throw new Error('Received ERROR as return value from AT command');
}

serialPort.unregister();
await serialPort.unregister();
return newResponses;
};