Skip to content

Use emoji instead of codicons for health status in resource tooltips #17489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamesNK wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Use emoji instead of codicons for health status in resource tooltips #17489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion extension/src/views/AspireAppHostTreeProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,14 @@ function buildResourceTooltip(resource: ResourceJson): vscode.MarkdownString {
if (reports) {
const entries = Object.entries(reports).sort(([a], [b]) => a.localeCompare(b));
for (const [name, report] of entries) {
const icon = report.status === HealthStatus.Healthy ? '$(pass)' : report.status === HealthStatus.Degraded ? '$(warning)' : '$(error)';
let icon = '❓';
if (report.status === HealthStatus.Healthy) {
icon = '✅';
Comment thread
JamesNK marked this conversation as resolved.
} else if (report.status === HealthStatus.Degraded) {
icon = '⚠️';
} else if (report.status === HealthStatus.Unhealthy) {
icon = '❌';
}
md.appendMarkdown(`${icon} ${name}: ${report.status ?? 'Unknown'}${report.description ? ` - ${report.description}` : ''}\n\n`);
Comment thread
JamesNK marked this conversation as resolved.
}
}
Expand Down
Loading