Use emoji instead of codicons for health status in resource tooltips#17489
Open
JamesNK wants to merge 1 commit into
Open
Use emoji instead of codicons for health status in resource tooltips#17489JamesNK wants to merge 1 commit into
JamesNK wants to merge 1 commit into
Conversation
Replace , , The term 'warning' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. codicon references with emoji (✅,⚠️ , ❌, ❓) in resource tooltip health check lines. Codicons were rendering as literal text in MarkdownString tooltips.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17489Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17489" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VS Code extension’s AppHost resource tooltips to display health check status using emoji instead of codicon references, avoiding the issue where $(pass)/$(warning)/$(error) render as literal text in MarkdownString tooltips.
Changes:
- Replaced codicon-based status prefixes with emoji for Healthy/Degraded/Unhealthy health report entries.
- Added a default “unknown” icon path when a report status doesn’t match known values.
mitchdenny
approved these changes
May 26, 2026
danegsta
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resource tooltips in the tree view display health check status using VS Code codicon references (
$(pass),$(warning),$(error)), but these render as literal text inMarkdownStringtooltips instead of icons.Before
The tooltip shows raw text like
$(pass) apiservice_https_/health_200_check: HealthyAfter
Health checks now display with emoji:
I used emoji because they have color. A VS Code icon would be the same color as text and not as noticable.
Changes
buildResourceTooltip()inAspireAppHostTreeProvider.ts