feat: runtime loadable custom dialect support - #523
Open
onur-ozkan wants to merge 7 commits into
Open
Conversation
Contributor
|
I read through some parts of it and here are some early comments:
|
onur-ozkan
force-pushed
the
runtime-loaded-dialects
branch
2 times, most recently
from
July 22, 2026 16:19
0fb88d0 to
0fd0f20
Compare
Signed-off-by: Onur Özkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
runtime-loaded-dialects
branch
from
July 22, 2026 16:22
0fd0f20 to
b7c5159
Compare
Signed-off-by: Onur Özkan <work@onurozkan.dev>
onur-ozkan
marked this pull request as ready for review
July 23, 2026 07:19
onur-ozkan
force-pushed
the
runtime-loaded-dialects
branch
from
July 23, 2026 07:19
58e961a to
4e1ce03
Compare
Member
Author
|
Do we have any bandwith to review this PR as a release candidate? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-mavlink currently supports only compile-time generated dialects. Users with a vehicle-specific or non-standard dialect must add the XML definition, regenerate bindings and rebuild their application before they can communicate with it.
That is not practical for applications that need to support arbitrary vehicles or allow users to provide their own dialect definitions. This change adds runtime-loaded dialect support so an application can accept a dialect XML path or uploaded file and communicate with that dialect without code generation and rebuilds.
Changes are simply:
Dialecttrait and dialect-aware read/write helpers for sync and async transports.DynamicDialectbehind thedialect-dynamicfeature.connect_with_dialectand async equivalents.runtime-dialectserial example and usage documentation.1:1 byte representation is covered with a unit test in
dynamicmodule.