bless clippy and fix CI errors

Signed-off-by: Onur Özkan <work@onurozkan.dev>

Author: onur-ozkan

mavlink-bindgen/src/parser.rs

@@ -916,13 +916,13 @@ impl MavMessage {
 
     #[inline(always)]
     fn emit_name_types(&self) -> (Vec<TokenStream>, usize) {
-        let mut encoded_payload_len: usize = 0;
+        let mut encoded_payload_size: usize = 0;
         let field_toks = self
             .fields
             .iter()
             .map(|field| {
                 let nametype = field.emit_name_type();
-                encoded_payload_len += field.mavtype.len();
+                encoded_payload_size += field.mavtype.size();
 
                 let description = field.emit_description();
 
@@ -960,7 +960,7 @@ impl MavMessage {
                 }
             })
             .collect::<Vec<TokenStream>>();
-        (field_toks, encoded_payload_len)
+        (field_toks, encoded_payload_size)
     }
 
     /// Generate description for the given message
@@ -1077,9 +1077,9 @@ impl MavMessage {
         let id = self.id;
         let name = self.name.clone();
         let extra_crc = extra_crc(self);
-        let (name_types, payload_encoded_len) = self.emit_name_types();
+        let (name_types, payload_encoded_size) = self.emit_name_types();
         assert!(
-            (1..=255).contains(&payload_encoded_len),
+            (1..=255).contains(&payload_encoded_size),
             "payload length must be between 1 and 255 bytes"
         );
 
@@ -1105,7 +1105,7 @@ impl MavMessage {
             }
 
             impl #msg_name {
-                pub const ENCODED_LEN: usize = #payload_encoded_len;
+                pub const ENCODED_LEN: usize = #payload_encoded_size;
                 #const_default
 
                 #[cfg(feature = "arbitrary")]
@@ -1126,7 +1126,7 @@ impl MavMessage {
                 const ID: u32 = #id;
                 const NAME: &'static str = #name;
                 const EXTRA_CRC: u8 = #extra_crc;
-                const ENCODED_LEN: usize = #payload_encoded_len;
+                const ENCODED_LEN: usize = #payload_encoded_size;
 
                 fn deser(_version: MavlinkVersion, __input: &[u8]) -> Result<Self, ::mavlink_core::error::ParserError> {
                     #deser_vars
@@ -1449,16 +1449,16 @@ impl MavType {
         }
     }
 
-    /// Size of a given Mavtype
-    pub fn len(&self) -> usize {
+    /// Encoded size of this MavType.
+    pub fn size(&self) -> usize {
         use self::MavType::*;
         match self {
             UInt8MavlinkVersion | UInt8 | Int8 | Char => 1,
             UInt16 | Int16 => 2,
             UInt32 | Int32 | Float => 4,
             UInt64 | Int64 | Double => 8,
             CharArray(size) => *size,
-            Array(t, size) => t.len() * size,
+            Array(t, size) => t.size() * size,
         }
     }
 
@@ -1487,7 +1487,7 @@ impl MavType {
             UInt16 | Int16 => 2,
             UInt32 | Int32 | Float => 4,
             UInt64 | Int64 | Double => 8,
-            Array(t, _) => t.len(),
+            Array(t, _) => t.size(),
         }
     }
 

mavlink-core/src/connection/direct_serial/mod.rs

@@ -3,5 +3,3 @@ mod sync;
 
 #[cfg(feature = "tokio")]
 mod r#async;
-
-pub use sync::SerialConnection;

mavlink-core/src/connection/direct_serial/sync.rs

@@ -69,7 +69,7 @@ impl Connectable for SerialConfig {
         Ok(Box::new(ConnectionCore::new_static(self.open()?)))
     }
 
-    fn connect_with_dialect<D: Dialect + 'static>(
+    fn connect_with_dialect<D: Dialect + Send + Sync + 'static>(
         &self,
         dialect: D,
     ) -> io::Result<DialectConnection<D>> {

mavlink-core/src/connection/file/mod.rs

@@ -3,5 +3,3 @@ mod sync;
 
 #[cfg(feature = "tokio")]
 mod r#async;
-
-pub use sync::FileConnection;

mavlink-core/src/connection/file/sync.rs

@@ -48,7 +48,7 @@ impl Connectable for FileConfig {
         Ok(Box::new(ConnectionCore::new_static(open(&self.address)?)))
     }
 
-    fn connect_with_dialect<D: Dialect + 'static>(
+    fn connect_with_dialect<D: Dialect + Send + Sync + 'static>(
         &self,
         dialect: D,
     ) -> io::Result<DialectConnection<D>> {

mavlink-core/src/connection/sync.rs

@@ -17,7 +17,7 @@ use crate::{
 };
 
 /// The byte-oriented half of a blocking transport.
-pub(crate) trait SyncTransport {
+pub(crate) trait SyncTransport: Send + Sync {
     type Reader: Read;
     type Writer: Write;
 
@@ -72,7 +72,7 @@ impl<T> ConnectionCore<T> {
 }
 
 /// A MAVLink connection
-pub trait MavConnection<M> {
+pub trait MavConnection<M>: Send + Sync {
     /// Receive a MAVLink message.
     ///
     /// May blocks until a valid frame is received, ignoring invalid messages.
@@ -259,7 +259,7 @@ macro_rules! impl_mav_connection {
     };
 }
 
-impl_mav_connection!([T: SyncTransport, D: Dialect] ConnectionCore<T, D>, D::Message, |core| &core.dialect);
+impl_mav_connection!([T: SyncTransport, D: Dialect + Send + Sync] ConnectionCore<T, D>, D::Message, |core| &core.dialect);
 impl_mav_connection!([T: SyncTransport, M: Message] ConnectionCore<T>, M, |core| &StaticDialect::<M>::new());
 
 /// A blocking MAVLink connection returned by [`connect`].
@@ -295,7 +295,7 @@ pub fn connect<M: Message + Sync + Send>(address: &str) -> io::Result<Connection
 /// Connect to a MAVLink node using a runtime-loaded dialect.
 ///
 /// The accepted address formats and errors are the same as [`connect`].
-pub fn connect_with_dialect<D: Dialect + 'static>(
+pub fn connect_with_dialect<D: Dialect + Send + Sync + 'static>(
     address: &str,
     dialect: D,
 ) -> io::Result<DialectConnection<D>> {
@@ -313,7 +313,7 @@ pub trait Connectable: Display {
     fn connect<M: Message>(&self) -> io::Result<Connection<M>>;
 
     /// Attempt to establish a blocking MAVLink connection with a runtime-loaded dialect.
-    fn connect_with_dialect<D: Dialect + 'static>(
+    fn connect_with_dialect<D: Dialect + Send + Sync + 'static>(
         &self,
         dialect: D,
     ) -> io::Result<DialectConnection<D>>;
@@ -332,7 +332,7 @@ impl Connectable for ConnectionAddress {
         }
     }
 
-    fn connect_with_dialect<D: Dialect + 'static>(
+    fn connect_with_dialect<D: Dialect + Send + Sync + 'static>(
         &self,
         dialect: D,
     ) -> io::Result<DialectConnection<D>> {

mavlink-core/src/connection/tcp/mod.rs

@@ -3,5 +3,3 @@ mod sync;
 
 #[cfg(feature = "tokio")]
 mod r#async;
-
-pub use sync::TcpConnection;

mavlink-core/src/connection/tcp/sync.rs

@@ -90,8 +90,7 @@ impl SyncTransport for TcpConnection {
     }
 
     fn next_send_header(&self, writer: &mut Self::Writer, header: &MavHeader) -> MavHeader {
-        let header = next_send_header(&mut writer.sequence, header);
-        header
+        next_send_header(&mut writer.sequence, header)
     }
 }
 
@@ -109,7 +108,7 @@ impl Connectable for TcpConfig {
         Ok(Box::new(ConnectionCore::new_static(self.open()?)))
     }
 
-    fn connect_with_dialect<D: Dialect + 'static>(
+    fn connect_with_dialect<D: Dialect + Send + Sync + 'static>(
         &self,
         dialect: D,
     ) -> io::Result<DialectConnection<D>> {

mavlink-core/src/connection/udp/mod.rs

@@ -3,5 +3,3 @@ mod sync;
 
 #[cfg(feature = "tokio")]
 mod r#async;
-
-pub use sync::UdpConnection;

mavlink-core/src/connection/udp/sync.rs

@@ -142,7 +142,7 @@ impl Connectable for UdpConfig {
     fn connect<M: crate::Message>(&self) -> io::Result<Connection<M>> {
         Ok(Box::new(ConnectionCore::new_static(self.open()?)))
     }
-    fn connect_with_dialect<D: Dialect + 'static>(
+    fn connect_with_dialect<D: Dialect + Send + Sync + 'static>(
         &self,
         dialect: D,
     ) -> io::Result<DialectConnection<D>> {