Fix arbitrary feature - #377
Merged
onur-ozkan merged 3 commits intoAug 22, 2025
Merged
Conversation
joaoantoniocardoso
marked this pull request as draft
August 22, 2025 04:15
joaoantoniocardoso
force-pushed
the
fix_arbitrary_feature
branch
from
August 22, 2025 04:15
bb06b0f to
e7275da
Compare
joaoantoniocardoso
marked this pull request as ready for review
August 22, 2025 14:11
joaoantoniocardoso
force-pushed
the
fix_arbitrary_feature
branch
from
August 22, 2025 14:12
e7275da to
fb408d5
Compare
onur-ozkan
approved these changes
Aug 22, 2025
onur-ozkan
left a comment
onur-ozkan
left a comment
Member
There was a problem hiding this comment.
Seems valid change, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #376 (merged)
This patch makes it build again for
--features=arbitrary, and it also adds the feature to the tests so we don't break it again until we actually start using it in tests (implemented in the next PR).