Wrap arrayvec::ArrayString and fix arbitrary feature - #345
Closed
joaoantoniocardoso wants to merge 6 commits into
Closed
Wrap arrayvec::ArrayString and fix arbitrary feature#345joaoantoniocardoso wants to merge 6 commits into
joaoantoniocardoso wants to merge 6 commits into
Conversation
joaoantoniocardoso
force-pushed
the
fix_string_arbitrary
branch
from
July 2, 2025 22:59
7a3be39 to
c70df24
Compare
joaoantoniocardoso
force-pushed
the
fix_string_arbitrary
branch
from
July 2, 2025 23:08
c70df24 to
8833314
Compare
joaoantoniocardoso
force-pushed
the
fix_string_arbitrary
branch
from
July 2, 2025 23:09
8833314 to
bae7024
Compare
joaoantoniocardoso
marked this pull request as draft
July 3, 2025 00:39
onur-ozkan
self-requested a review
July 3, 2025 13:21
onur-ozkan
reviewed
Jul 4, 2025
| - uses: dtolnay/rust-toolchain@stable | ||
| - name: Run internal tests | ||
| run: cargo test --verbose --features ${{ matrix.dialect }} ${{ matrix.signing }} -- --nocapture | ||
| run: cargo test --verbose --features arbitrary,${{ matrix.dialect }} ${{ matrix.signing }} -- --nocapture |
Member
There was a problem hiding this comment.
Should arbitrary be enabled together with all the dialect features?
Contributor
Author
There was a problem hiding this comment.
Not necessarily now, but it will be used in their tests, soon.
Member
|
I will do the review once the draft mark is removed. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The
arbitraryfeature was already broken, but on the last PR (#343), I accidentally made it worse. For instance, the feature broke because it wasn't enabled in the CI.To avoid having to rely on the arrayvec devs to implement Arbitrary the way we need, I'm wrapping
arrayvec::ArrayStringand calling itMavString. By doing so, we also gain better control over the API, making it possible to keep compatibility even if we decide to move from arrayvec to something else.To help a bit on the API side, I implemented
TryFrom<String> for MavString, too.Closes #344