[dv,darjeeling] Fix some duplicate connectivity testplan items#30669
Merged
Conversation
Fix some duplicate Darjeeling chip connectivity items which were preventing us from upgrading to a newer DVSim version, which now produces errors in these cases. These were likely caused by bad renames in the past when changing Darjeeling to use external clocks instead of the clkmgr's IODIV2 and IODIV4 clocks. Many other parts of the tests look incorrect (e.g. references to flash_ctrl) and out of date, but the scope of this commit is limited to only removing the duplicate testplan items to allow DVSim to be bumped. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
rswarbrick
approved these changes
Jul 6, 2026
rswarbrick
left a comment
rswarbrick
left a comment
Contributor
There was a problem hiding this comment.
This definitely looks like it's the right thing to do. Goodness knows whether the connectivity checks will actually work (I strongly suspect not!), but that shouldn't gate this work.
Contributor
Author
I agree - these likely do not work properly in the first place (Darjeeling is referencing flash_ctrl) and are instead a bad copy-paste. If there is value in resurrecting these checks for Darjeeling in the future then that should be handled separately; for now we should just aim to unblock the DVSim upgrade. |
hcallahan-lowrisc
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some duplicate Darjeeling chip connectivity items which were preventing us from upgrading to a newer DVSim version, which now produces errors in these cases: https://github.com/lowRISC/opentitan-private-ci/actions/runs/28666658279/job/85019992031#step:5:296
These were likely caused by bad renames in the past when changing Darjeeling to use external clocks instead of the clkmgr's IODIV2 and IODIV4 clocks (see #26758). Many other parts of the tests look incorrect (e.g. references to flash_ctrl) and out of date, but the scope of this PR is limited to only removing the duplicate testplan items to allow the DVSim version to be bumped.