Skip to content

Commit 0e745b4

Browse files
committed
[dv,darjeeling] Fix some duplicate connectivity testplan items
Fix some duplicate Darjeeling chip connectivity items which were preventing us from upgrading to a newer DVSim version, which now produces errors in these cases. These were likely caused by bad renames in the past when changing Darjeeling to use external clocks instead of the clkmgr's IODIV2 and IODIV4 clocks. Many other parts of the tests look incorrect (e.g. references to flash_ctrl) and out of date, but the scope of this commit is limited to only removing the duplicate testplan items to allow DVSim to be bumped. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
1 parent fa5c0ef commit 0e745b4

1 file changed

Lines changed: 12 additions & 59 deletions

File tree

hw/top_darjeeling/data/chip_conn_testplan.hjson

Lines changed: 12 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,14 @@
322322
/////////////////////////
323323
{
324324
name: clkmgr_clk_io_infra
325-
desc: '''Verify clkmgr's `clk_io_infra` is connected to the following block's clock
325+
desc: '''Verify clkmgr's `clk_io_infra` is connected to the following blocks' clock
326326
input:
327327
- flash_ctrl clk_otp_i
328328
- sram_ctrl main clk_otp_i
329329
- sram_ctrl retention clk_i
330330
- sram_ctrl retention clk_otp_i
331331
- xbar_main clk_fixed_i
332+
- xbar_main clk_spi_host0_i
332333
- xbar_peri clk_peri_i
333334
'''
334335
stage: V2
@@ -337,6 +338,7 @@
337338
"clkmgr_infra_clk_sram_ctrl_ret_clk",
338339
"clkmgr_infra_clk_sram_ctrl_ret_otp_clk",
339340
"clkmgr_infra_clk_xbar_main_fixed_clk",
341+
"clkmgr_infra_clk_xbar_main_spi_host0_clk",
340342
"clkmgr_infra_clk_xbar_peri_peri_clk"]
341343
tags: ["conn"]
342344
}
@@ -361,15 +363,6 @@
361363
"clkmgr_infra_clk_xbar_main_main_clk"]
362364
tags: ["conn"]
363365
}
364-
{
365-
name: clkmgr_clk_io_infra
366-
desc: '''Verify clkmgr's `clk_io_infra` is connected to the following block's clock input:
367-
- xbar_main's clk_spi_host0_i
368-
'''
369-
stage: V2
370-
tests: ["clkmgr_infra_clk_xbar_main_spi_host0_clk"]
371-
tags: ["conn"]
372-
}
373366

374367
/////////////////////////
375368
// clkmgr_peri.csv //
@@ -380,12 +373,14 @@
380373
input:
381374
- gpio clk_i
382375
- spi_device clk_i
376+
- spi_host clk_i
383377
- i2c0 clk_i
384378
- uart0 clk_i
385379
'''
386380
stage: V2
387381
tests: ["clkmgr_peri_clk_gpio_clk",
388382
"clkmgr_peri_clk_spi_device_clk",
383+
"clkmgr_peri_clk_spi_host0_clk",
389384
"clkmgr_peri_clk_i2c0_clk",
390385
"clkmgr_peri_clk_uart0_clk"]
391386
tags: ["conn"]
@@ -400,15 +395,6 @@
400395
tests: ["clkmgr_peri_clk_spi_device_scan_clk"]
401396
tags: ["conn"]
402397
}
403-
{
404-
name: clkmgr_clk_io_peri
405-
desc: '''Verify clkmgr's `clk_io_peri` is connected to the following block's clock input:
406-
- spi_host0's clk_i
407-
'''
408-
stage: V2
409-
tests: ["clkmgr_peri_clk_spi_host0_clk"]
410-
tags: ["conn"]
411-
}
412398

413399
/////////////////////////
414400
// clkmgr powerup //
@@ -429,7 +415,7 @@
429415
"clkmgr_powerup_clk_pwrmgr_clk",
430416
"clkmgr_powerup_clk_pwrmgr_lc_clk",
431417
"clkmgr_powerup_clk_rstmgr_por_clk",
432-
"clkmgr_powerup_clk_rstmgr_io4_clk"]
418+
"clkmgr_powerup_clk_rstmgr_io_clk"]
433419
tags: ["conn"]
434420
}
435421
{
@@ -455,20 +441,6 @@
455441
tests: ["clkmgr_powerup_clk_rstmgr_main_clk"]
456442
tags: ["conn"]
457443
}
458-
{
459-
name: clkmgr_clk_io_powerup
460-
desc: '''Verify clkmgr's `clk_io_powerup` is connected to rstmgr's io clock.'''
461-
stage: V2
462-
tests: ["clkmgr_powerup_clk_rstmgr_io_clk"]
463-
tags: ["conn"]
464-
}
465-
{
466-
name: clkmgr_clk_io_div2_powerup
467-
desc: '''Verify clkmgr's `clk_io_div2_powerup` is connected to rstmgr's io_div2 clock.'''
468-
stage: V2
469-
tests: ["clkmgr_powerup_clk_rstmgr_io2_clk"]
470-
tags: ["conn"]
471-
}
472444

473445
/////////////////////////
474446
// clkmgr_secure.csv //
@@ -625,9 +597,9 @@
625597
tags: ["conn"]
626598
}
627599

628-
//////////////////////////
629-
// lc_ctrl_broadcast.sv //
630-
//////////////////////////
600+
///////////////////////////
601+
// lc_ctrl_broadcast.csv //
602+
///////////////////////////
631603
{
632604
name: lc_escalate_en
633605
desc: '''Verify lc_ctrl's `lc_escalate_en_o` is connected to the following blocks'
@@ -736,7 +708,7 @@
736708
tags: ["conn"]
737709
}
738710
/////////////////////////
739-
// pwrmgr_rstmgr.sv //
711+
// pwrmgr_rstmgr.csv //
740712
/////////////////////////
741713
{
742714
name: pwrmgr_rst_lc_req
@@ -861,13 +833,6 @@
861833
tests: ["rstmgr_lc_aon_clkmgr_rst_main_ni"]
862834
tags: ["conn"]
863835
}
864-
{
865-
name: rst_lc_io_aon
866-
desc: '''Verify rstmgr's rst_lc_io_n[0] is connected to clkmgr's rst_io_ni.'''
867-
stage: V2
868-
tests: ["rstmgr_lc_io_aon_clkmgr_rst_io_ni"]
869-
tags: ["conn"]
870-
}
871836
{
872837
name: rst_por_aon_aon
873838
desc: '''Verify rstmgr's rst_por_aon_n[0] is connected to pwrmgr's rst_slow_ni.'''
@@ -889,13 +854,6 @@
889854
tests: ["rstmgr_por_aon_clkmgr_rst_root_main_ni"]
890855
tags: ["conn"]
891856
}
892-
{
893-
name: rst_por_io_aon
894-
desc: '''Verify rstmgr's rst_por_io_n[0] is connected to clkmgr's rst_root_io_ni.'''
895-
stage: V2
896-
tests: ["rstmgr_por_io_aon_clkmgr_rst_root_io_ni"]
897-
tags: ["conn"]
898-
}
899857
{
900858
name: rst_por_io_div2_aon
901859
desc: '''Verify rstmgr's rst_por_io_div2_n[0] is connected to clkmgr's rst_root_io_div2_ni.'''
@@ -932,13 +890,6 @@
932890
tests: ["rstmgr_spi_host0_d0_spi_host0_rst_ni"]
933891
tags: ["conn"]
934892
}
935-
{
936-
name: rst_sys_io_d0
937-
desc: '''Verify rstmgr's rst_sys_io_n[1] is connected to xbar_main's rst_spi_host0_ni.'''
938-
stage: V2
939-
tests: ["rstmgr_sys_io_d0_xbar_main_rst_spi_host0_ni"]
940-
tags: ["conn"]
941-
}
942893
{
943894
name: rst_sys_io_aon
944895
desc: '''Verify rstmgr's rst_sys_io_n[0] is connected to the following:
@@ -958,6 +909,7 @@
958909
- rv_timer's rst_ni
959910
- uart0's rst_ni
960911
- xbar_main's rst_fixed_ni
912+
- xbar_main's rst_spi_host0_ni
961913
- xbar_peri's rst_peri_ni
962914
'''
963915
stage: V2
@@ -966,6 +918,7 @@
966918
"rstmgr_sys_io_d0_rv_timer_rst_ni",
967919
"rstmgr_sys_io_d0_uart0_rst_ni",
968920
"rstmgr_sys_io_d0_xbar_main_rst_fixed_ni",
921+
"rstmgr_sys_io_d0_xbar_main_rst_spi_host0_ni",
969922
"rstmgr_sys_io_d0_xbar_peri_rst_peri_ni"]
970923
tags: ["conn"]
971924
}

0 commit comments

Comments
 (0)