Initiate work on PutObjectTagging ref PR#71 and issue #72#75
Open
johannesboyne wants to merge 6 commits into
Open
Initiate work on PutObjectTagging ref PR#71 and issue #72#75johannesboyne wants to merge 6 commits into
johannesboyne wants to merge 6 commits into
Conversation
|
SonarCloud Quality Gate failed.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 65.94% 65.74% -0.21%
==========================================
Files 28 28
Lines 2693 2744 +51
==========================================
+ Hits 1776 1804 +28
- Misses 651 666 +15
- Partials 266 274 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
@elgohr see this implementation as a first step, your test case is running with this but might be good to check out your real-world case against this to see, whether it actually works and behaves as expected. |
5b1d549 to
439bdb7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










This fixes issue #72 and builds on PR #71
If the general implementation would work like this as expected, we could extend the test cases a bit and then merge this PR.