🐛 Add test for changed body when putting tag#71
Conversation
|
Thanks a lot for the test-case! As it currently fails (obviously), it would be best to also include the implementation! I have not looked at the implementation details behind the tagging, but it looks straight forward here https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObjectTagging.html The implementation would be probably as follows:
Are you open to that? Just adding the failing test-case could cause other implementations to fail if they check libs for test-cases. |
|
So how would you put that into https://github.com/johannesboyne/gofakes3/blob/master/backend.go#L133 ? |
|
Worked on in PR #75 |
|
Would have been great if you cherry-picked my commit - but I'm happy anyway for the topic to move on |
At the moment the body is changed when putting a tag.
I just created the test . Could you please have a look at the implementation?