Skip to content

Run eslint autofix as a part of client format when using Makefile #16586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvdbeek merged 1 commit into from
Aug 25, 2023
Merged

Run eslint autofix as a part of client format when using Makefile #16586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,10 @@ client-production: client-node-deps ## Rebuild client-side artifacts for a produ
client-production-maps: client-node-deps ## Rebuild client-side artifacts for a production deployment with sourcemaps.
$(IN_VENV) cd client && $(NODE_ENV) yarn run build-production-maps

client-format: client-node-deps ## Reformat client code
client-lint-autofix: client-node-deps ## Automatically fix linting errors in client code
$(IN_VENV) cd client && yarn run eslint --quiet --fix

client-format: client-node-deps client-lint-autofix ## Reformat client code, ensures autofixes are applied first

@jmchilton jmchilton Aug 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed #16462 - this plus that are amazing! Thanks so much for these improvements to the dev experience @dannon - I love them.

$(IN_VENV) cd client && yarn run format

client-dev-server: client-node-deps ## Starts a webpack dev server for client development (HMR enabled)
Expand Down