Run eslint autofix as a part of client format when using Makefile - #16586
Merged
Conversation
formatting process.
dannon
changed the title
dannon
marked this pull request as ready for review
August 23, 2023 14:24
jmchilton
reviewed
Aug 23, 2023
| client-lint-autofix: client-node-deps ## Automatically fix linting errors in client code | ||
| $(IN_VENV) cd client && yarn run eslint --quiet --fix | ||
|
|
||
| client-format: client-node-deps client-lint-autofix ## Reformat client code, ensures autofixes are applied first |
Member
jmchilton
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref conversation in UI/UX -- thanks @jmchilton, it's a good idea -- these are all stable fixes at this point and this makes it a bit more convenient for folks who use the make targets. Folks can use the package scripts to format without this behavior if desired.
How to test the changes?
(Select all options that apply)
make client-formatLicense