Force makefile client targets to use .venv-shipped node if it exists - #16462
Merged
Conversation
dannon
marked this pull request as ready for review
July 25, 2023 14:27
nsoranzo
reviewed
Jul 25, 2023
Member
Author
|
Just realized I did the same thing Marius did in #16461 w/ the chromedriver fail. I can strip that back out if need be. |
mvdbeek
added
area/documentation
kind/refactoring
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16422
I think it's fine to assume when using these from the Makefile, if a .venv exists, use it for the bundled node/yarn. People wanting to use their own node or who are otherwise tinkering with client development will use the package scripts directly anyway.
How to test the changes?
(Select all options that apply)
License