Final shader improvements (reopened)

[RealEdwardS]

Describe your changes

Added time elapsed from the app start as a uniform property for final shader application.

Issue ticket number and link if any

Checklist for finalizing the PR

• I have performed a self-review of my code
• I have added tests for new features and bugfixes
• I have added documentation for new features
• If it is a modifying the libf3d API, I have updated bindings
• If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

[github-actions]

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

[mwestphal]

Still not ok ^^

[mwestphal]

I can take care of it if you want.

[RealEdwardS]

I can take care of it if you want.

Yes please

[mwestphal]

here it is: #2935

Please next time you want to merge/rebase on master, please reach out on discord and I will assist.

[mwestphal]

Still working on this @RealEdwardS ?

[RealEdwardS]

Still working on this @RealEdwardS ?

I think it's ready for review, unless there's something I'm missing?

[mwestphal]

I think it's ready for review, unless there's something I'm missing?

You need to ask for review if you want a review :)

[mwestphal]

Well, first you have to recover the branch I provided to you here: #2935, do you need help with that ?

[RealEdwardS]

Well, first you have to recover the branch I provided to you here: #2935, do you need help with that ?

I think I was able to fix everything?

[mwestphal]

changes needed, but a review from meak too.

[Meakk]

The implementation and test is fine. OK to merge when the discussions are addressed.

[snoyer]

Do we know if/how that plays out in non-interactive mode, like rendering a video frame by frame? Would we be able to set the time variable with an API in the future?

[RealEdwardS]

@Meakk, @mwestphal. I think it's ready for review :D

[mwestphal]

@Meakk, @mwestphal. I think it's ready for review :D

please use review mechanism top right.

[RealEdwardS]

What’s the review mechanism?

[mwestphal]

What’s the review mechanism?

You just found it :)

[mwestphal]

LGTM but I defer to @Meakk

[Meakk]

Looks good :)
I've run the full CI and will merge it if green

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.17%. Comparing base (f7bf2e2) to head (7837916).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2932   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files         210      210           
  Lines       16729    16733    +4     
=======================================
+ Hits        16256    16260    +4     
  Misses        473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mwestphal]

CI is green, merging.

[mwestphal]

Thanks for the contribution @RealEdwardS !