Show language banner image in the properties Editor - #62
Open
wolfgang-ch wants to merge 1 commit into
Open
Conversation
When country is not available in the locale then the language is used to show the country banner
Copilot AI
added a commit
to tlcsdm/eclipse-rbe
that referenced
this pull request
May 15, 2026
Port of upstream PR essiembre#62: when a locale has no country code (e.g. 'de' instead of 'de_DE'), fall back to using the language code to load a banner image from the countries/ icon folder, rather than always showing the blank placeholder. Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/9779990f-d04d-44fd-bc76-f20f89847b06 Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
unknowIfGuestInDream
added a commit
to tlcsdm/eclipse-rbe
that referenced
this pull request
May 15, 2026
…s unavailable (#45) * Initial plan * feat(ui): show language banner image when country image is not available Port of upstream PR essiembre#62: when a locale has no country code (e.g. 'de' instead of 'de_DE'), fall back to using the language code to load a banner image from the countries/ icon folder, rather than always showing the blank placeholder. Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/9779990f-d04d-44fd-bc76-f20f89847b06 Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com> * refactor(ui): rename countryLanguage to languageCode for clarity Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/9779990f-d04d-44fd-bc76-f20f89847b06 Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a country is not available in a properties file name, then the country banner is not displayed.
With this feature, the language in a locale is used to show the country banner.