feat(ui): Show language banner image as fallback when country image is unavailable - #45
Merged
unknowIfGuestInDream merged 3 commits intoMay 15, 2026
Conversation
Port of upstream PR essiembre#62: when a locale has no country code (e.g. 'de' instead of 'de_DE'), fall back to using the language code to load a banner image from the countries/ icon folder, rather than always showing the blank placeholder. Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/9779990f-d04d-44fd-bc76-f20f89847b06 Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/9779990f-d04d-44fd-bc76-f20f89847b06 Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add language banner image in properties editor
feat(ui): Show language banner image as fallback when country image is unavailable
May 15, 2026
unknowIfGuestInDream
deleted the
copilot/feature-show-language-banner-image
branch
May 15, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a locale has only a language component (e.g.
de,fr,zh) and no country code, the properties editor always showed a blank placeholder image instead of any meaningful banner.Change
In
BundleEntryComposite.loadCountryIcon, added anelse iffallback that attempts to resolve a banner using the language code when no country code is present:Port of essiembre/eclipse-rbe#62.