Skip to content

Filter cancelled calendar events before sync updates#526

Open
Ivanyanqi wants to merge 1 commit into
derekantrican:masterfrom
Ivanyanqi:fix/filter-cancelled-events-invalid-start-time
Open

Filter cancelled calendar events before sync updates#526
Ivanyanqi wants to merge 1 commit into
derekantrican:masterfrom
Ivanyanqi:fix/filter-cancelled-events-invalid-start-time

Conversation

@Ivanyanqi

Copy link
Copy Markdown

This PR addresses issue #315 (Invalid start time on calendar.events.update) by excluding cancelled Google events from the in-memory update set.

What changed

  • After loading existing calendar events (showDeleted: false), filter out any events whose status is cancelled.
  • Add a log line that reports how many cancelled events were filtered.

Why

Some recurring-event edge cases can still return cancelled events even with showDeleted=false. When those are treated as active and passed into update logic, they can trigger Invalid start time failures.

Scope

  • Minimal runtime behavior change in startSync event-loading flow only.
  • No config changes.

Validation

  • Static logic validation against issue repro details and existing sync flow.
  • Change is isolated to existing-event pre-processing before ID/MD5 mapping.

Closes #315

@Ivanyanqi

Copy link
Copy Markdown
Author

This PR is a minimal fix for the recurring-event edge case behind Invalid start time.

It filters cancelled Google Calendar events before sync updates so they are never treated as active update targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Invalid start time' error from calendar.events.update

1 participant