Guard against cancelled existing events causing Invalid start time#527
Open
xiongyindong wants to merge 1 commit into
Open
Guard against cancelled existing events causing Invalid start time#527xiongyindong wants to merge 1 commit into
xiongyindong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch addresses the recurring
Invalid start timefailure reported in #315 when syncing updates against existing Google events that are alreadycancelled.What changed
Code.gs(startSync), filter out existing calendar events withstatus === "cancelled"immediately after fetch (with a log count).Helpers.gs(processEvent), add a second safety guard: if a matched existing event is cancelled, skipCalendar.Events.updateand log the skip.Why this differs from existing fix attempts
There is already a focused filter fix in #526. This PR keeps that idea and adds a second update-path guard to handle edge cases where cancelled events can still appear during update flow.
Scope
Validation