Skip to content

fix(welcome): replace stale ? shortcut with /hotkeys in tips panel #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oldschoola wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(welcome): replace stale ? shortcut with /hotkeys in tips panel #3315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/coding-agent/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
### Fixed

- Fixed all extension loading silently failing on the cross-compiled `omp-darwin-arm64` release binary (downloaded directly or via a Homebrew tap wrapper) because `__computeBunfsPackageRoot` mis-handled `import.meta.dir = "//root/omp-darwin-arm64"`. Bun 1.3.14 reports `<bunfs-root>/<binary-name>` for the compiled entry's `import.meta.dir`, but the pre-fix function joined `metaDir + "packages"` and produced `/root/omp-darwin-arm64/packages` — the binary basename was baked into every bunfs path, so the TypeBox/legacy-pi shims and every `@oh-my-pi/pi-*` package-root override failed `existsSync` validation and `resolveCanonicalPiSpecifier` fell through to a bunfs `Bun.resolveSync` that also could not find the module. The function now detects the bunfs-root + binary-basename shape (`path.basename(path.dirname(metaDir)) === "root"`) and strips the trailing binary segment by slicing the original `metaDir`; the production bunfs shim join path also preserves Bun's bunfs-native `//root` / `B:\~BUN\root` prefix that `path.join` would otherwise collapse. ([#3329](https://github.com/can1357/oh-my-pi/issues/3329))
- Fixed the welcome panel advertising `? for keyboard shortcuts` after the `?` shortcut was deliberately removed (commit dcf482c4c). The tips section now points users at `/hotkeys` instead. ([#1614](https://github.com/can1357/oh-my-pi/issues/1614))

## [16.1.16] - 2026-06-23

### Breaking Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/coding-agent/src/modes/components/welcome.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ export class WelcomeComponent implements Component {
// Right column
const rightLines = [
` ${theme.bold(theme.fg("accent", "Tips"))}`,
` ${theme.fg("dim", "?")}${theme.fg("muted", " for keyboard shortcuts")}`,
` ${theme.fg("dim", "/hotkeys")}${theme.fg("muted", " for keyboard shortcuts")}`,
` ${theme.fg("dim", "#")}${theme.fg("muted", " for prompt actions")}`,
` ${theme.fg("dim", "/")}${theme.fg("muted", " for commands")}`,
` ${theme.fg("dim", "!")}${theme.fg("muted", " to run bash")}`,
Expand Down
Loading