fix(welcome): replace stale ? shortcut with /hotkeys in tips panel#3315
Open
oldschoola wants to merge 1 commit into
Open
fix(welcome): replace stale ? shortcut with /hotkeys in tips panel#3315oldschoola wants to merge 1 commit into
oldschoola wants to merge 1 commit into
Conversation
roboomp
reviewed
Jun 23, 2026
roboomp
left a comment
roboomp
left a comment
Collaborator
There was a problem hiding this comment.
lgtm — narrowest possible fix for #1614. Verified:
dcf482c4c4does remove the?→ hotkeys binding fromCustomEditor/InputController, sowelcome.ts:333was the last advertiser./hotkeysis a real slash command (packages/coding-agent/src/slash-commands/builtin-registry.ts:1070, handler atcommand-controller.ts:491), so the replacement matches actual behavior.- No other src/test references to the stale
? for keyboard shortcutsstring remain. - CHANGELOG entry sits under
[Unreleased] / FixedperAGENTS.mdand links #1614.
Thanks @oldschoola.
The welcome panel advertised '? for keyboard shortcuts' even though the ? shortcut was deliberately removed in commit dcf482c ('fix(editor): removed ? shortcut that opened hotkeys when input was empty'). Users typing ? on an empty prompt got a literal question mark submitted to the model instead of the help panel they expected. Replace the stale claim with '/hotkeys for keyboard shortcuts', matching the actual command that opens the shortcut reference. Fixes can1357#1614
oldschoola
force-pushed
the
fix/welcome-stale-question-mark-shortcut-1614
branch
from
a0d9fb3 to
eb56da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The welcome panel advertised
? for keyboard shortcutseven though the?shortcut was deliberately removed in commitdcf482c4c("fix(editor): removed?shortcut that opened hotkeys when input was empty"). Users typing?on an empty prompt got a literal question mark submitted to the model instead of the help panel they expected.Fixes #1614
Changes
? for keyboard shortcutswith/hotkeys for keyboard shortcutsin the welcome panel tips section (welcome.ts:333).This is the narrowest fix (option 1 from the issue discussion): honor the maintainer's 2026-05-31 decision to remove
?and stop advertising it. Users who want the shortcut reference use/hotkeysexplicitly.Tests
bun checkpasses