Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/zaxxer/hikari/HikariConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ public void setCredentialsProviderClassName(String credentialsProviderClassName)

try {
this.credentialsProvider = createInstance(credentialsProviderClassName, HikariCredentialsProvider.class);
this.exceptionOverrideClassName = credentialsProviderClassName;
this.credentialsProviderClassName = credentialsProviderClassName;
}
catch (Exception e) {
throw new RuntimeException("Failed to instantiate class " + credentialsProviderClassName, e);
Expand Down
14 changes: 14 additions & 0 deletions src/test/java/com/zaxxer/hikari/HikariConfigTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,18 @@ String getLog() {
return log;
}
}

@Test
public void testSetCredentialsProviderClassNameSetsItsOwnField() {
HikariConfig config = new HikariConfig();
String providerClass = "com.zaxxer.hikari.pool.TestCredentials$TestCredentialsProvider";

config.setCredentialsProviderClassName(providerClass);

// the setter must record the credentials-provider class name
assertEquals(providerClass, config.getCredentialsProviderClassName());
// ...and must NOT overwrite the unrelated SQLExceptionOverride class name
assertNull(config.getExceptionOverrideClassName());
}

}