Fix setCredentialsProviderClassName storing the value in the wrong field#2405
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Conversation
setCredentialsProviderClassName() assigned the class name to exceptionOverrideClassName instead of credentialsProviderClassName. As a result getCredentialsProviderClassName() always returned null, and the unrelated SQLExceptionOverride class name was silently overwritten, so HikariCP would later try to load the credentials provider class as a SQLExceptionOverride. Assign the correct field, mirroring setExceptionOverrideClassName(). Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HikariConfig.setCredentialsProviderClassName(String)assigns the class name to theexceptionOverrideClassNamefield instead ofcredentialsProviderClassName:Two consequences:
getCredentialsProviderClassName()always returnsnull, because the field is never assigned.exceptionOverrideClassName(aSQLExceptionOverrideclass name) is silently overwritten, so HikariCP later tries to load the credentials-provider class as aSQLExceptionOverride.This assigns the correct field, mirroring
setExceptionOverrideClassName(). Includes a regression test.