Migration: Use TimeTravel in Unit Tests - #918
Open
bolshakov wants to merge 1 commit into
Open
Conversation
Review price tag🟢 36 effective lines — about 5–11 min (down from 44–111 min) of focused review (based on 200–500 lines/hour). This is within the range where reviewers find the most issues per line, and small changes usually receive feedback the fastest. Spread across many files. This PR changes 10 files — more than about 9 in 10 PRs touch. Each extra file is another piece of context a reviewer has to load and hold at once. Why these numbers?These minutes are what careful defect-finding costs at 200–500 lines/hour — the rate review studies report, not how long a skim takes. "Effective lines" already exclude generated files and lockfiles. Treat the rates and the 200/400 thresholds as guardrails, not laws. |
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 1, 2026 20:30
0773451 to
eba1557
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 2, 2026 07:45
eba1557 to
1c8fafa
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 2, 2026 08:50
1df8687 to
7b96266
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 2, 2026 09:10
7b96266 to
1df8687
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 2, 2026 09:13
1df8687 to
5b4e165
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 2, 2026 09:51
5b4e165 to
1df8687
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 2, 2026 10:10
1df8687 to
6f43628
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
2 times, most recently
from
September 2, 2026 10:17
fdb0781 to
9b21b43
Compare
bolshakov
force-pushed
the
feature/use-time-travel-helper-in-tests
branch
from
September 2, 2026 11:13
9b21b43 to
a547a41
Compare
bolshakov
marked this pull request as ready for review
September 2, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
TimeTravelfor metrics snapshots, state transitions, recovery timingPart of: 3-phase refactoring (Phase 2/3)
now())