Redis-Synchronized Time: Infrastructure & TimeTravel Helper - #917
Open
bolshakov wants to merge 6 commits into
Open
Redis-Synchronized Time: Infrastructure & TimeTravel Helper#917bolshakov wants to merge 6 commits into
bolshakov wants to merge 6 commits into
Conversation
Review price tag🟢 172 effective lines — about 21–52 min of focused review (based on 200–500 lines/hour). This is within the range where reviewers find the most issues per line, and small changes usually receive feedback the fastest. Why these numbers?These minutes are what careful defect-finding costs at 200–500 lines/hour — the rate review studies report, not how long a skim takes. "Effective lines" already exclude generated files and lockfiles. Treat the rates and the 200/400 thresholds as guardrails, not laws. |
bolshakov
force-pushed
the
feature/use-redis-time
branch
2 times, most recently
from
September 1, 2026 18:50
52fd534 to
b142e99
Compare
bolshakov
force-pushed
the
feature/use-redis-time
branch
6 times, most recently
from
September 2, 2026 10:11
a0f55c1 to
4b31581
Compare
bolshakov
force-pushed
the
feature/use-redis-time
branch
from
September 2, 2026 11:13
4b31581 to
0c1f82f
Compare
bolshakov
marked this pull request as ready for review
September 2, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates infrastructure for Redis-synchronized time across distributed Stoplight instances, eliminating clock skew. Implements:
now()Lua function that reads fromredis.call("TIME")for server-authoritative timestamps@includedirectives) supporting multiple lookup pathsStoplight::TimeTravelhelper for deterministic test time control with Redis stack awarenessTime-dependent logic (recovery windows, metrics snapshots, state transitions) requires consistent time across distributed instances. This phase creates the foundation.
Part of: 3-phase refactoring (Phase 1/3) - See GitHub stack below.
Considered alternatives:
FUNCTION LOAD/PCALL- convenient, but essentially requires a migration to be executed before the code