Add TBS Unify Pro32 DP VTX table#583
Conversation
📝 WalkthroughWalkthroughAdds a community VTX preset for TBS Unify Pro32 DP SA 2.1, including metadata, disclaimer text, firmware version coverage, and the full band, channel, power, and label table. ChangesVTX preset definition
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt`:
- Around line 10-14: The preset description for Unify_Pro32_DP_SA2_1 is missing
the caveat that the all-bands option could not be made to work in Betaflight
testing. Update the DESCRIPTION comments in this VTX table so they clearly note
this limitation alongside the existing manufacturer and safety notes, keeping
the wording consistent with the other preset metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 62edf1ce-d28f-4410-95fb-d914d64f52d8
📒 Files selected for processing (1)
presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt
| #$ DESCRIPTION: VTX table for TBS Unify Pro32 DP SA 2.1. NOTE 1. Max power set to 65dB as it will force the VTX to output max power. NOTE 2. This table is as provided by the manufacturer. | ||
| #$ DESCRIPTION: !!! Make sure to use the correct broad band antenna to avoid damaging the VTX !!! | ||
| #$ DESCRIPTION: The information provided on this preset is for educational and entertainment purposes only. Betaflight makes no representations as to the safety or legality of the use of any information provided herein. End users assume all responsibility and liability for ensuring they are complying with all relevant laws and regulations. | ||
| #$ DESCRIPTION: ---------- | ||
| #$ DESCRIPTION: Using the VTX tables as provided may be in breach of your local RF laws. It is up to the end user to research and comply with local regulations and in using these presets the user assumes all liability associated with breaching local regulations. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Document the missing “all bands” limitation.
The PR intent says this preset could not make the all-bands option work in Betaflight testing, but that caveat is not reflected here. Please add it to avoid presenting the preset as fully complete when it isn’t.
🧰 Tools
🪛 LanguageTool
[style] ~11-~11: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 1844 characters long)
Context: ... band antenna to avoid damaging the VTX !!! #$ DESCRIPTION: The information provide...
(EN_EXCESSIVE_EXCLAMATION)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt` around lines 10 - 14, The preset
description for Unify_Pro32_DP_SA2_1 is missing the caveat that the all-bands
option could not be made to work in Betaflight testing. Update the DESCRIPTION
comments in this VTX table so they clearly note this limitation alongside the
existing manufacturer and safety notes, keeping the wording consistent with the
other preset metadata.
|
Preview URL: https://pr583.betaflight-firmware-presets.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt (1)
10-10: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove extra space in keywords.
"unify , pro32" has an extra space before the comma. Change to "unify, pro32" for consistency.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt` at line 10, The keywords line contains an unnecessary space before the comma in the Unify Pro32 preset text. Update the keywords entry in the preset file so the comma is attached to the preceding word, matching the existing keyword formatting style and keeping the list consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt`:
- Line 12: The DESCRIPTION for the Unify_Pro32_DP_SA2_1 preset is missing the
explicit limitation that the all-bands option was excluded because it could not
be made to work in Betaflight during testing. Update the DESCRIPTION entry in
this preset file to add a clear note about that limitation alongside the
existing power and manufacturer notes, so users can see that the preset is
intentionally incomplete.
---
Nitpick comments:
In `@presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt`:
- Line 10: The keywords line contains an unnecessary space before the comma in
the Unify Pro32 preset text. Update the keywords entry in the preset file so the
comma is attached to the preceding word, matching the existing keyword
formatting style and keeping the list consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ace89eb7-543a-4fd6-bc59-9679809a1016
📒 Files selected for processing (1)
presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt
| #$ STATUS: COMMUNITY | ||
| #$ KEYWORDS: vtx, vtx table, tbs, unify , pro32, DP, SA 2.1 | ||
| #$ AUTHOR: andybrwr | ||
| #$ DESCRIPTION: VTX table for TBS Unify Pro32 DP SA 2.1. NOTE 1. Max power set to 65dB as it will force the VTX to output max power. NOTE 2. This table is as provided by the manufacturer. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚖️ Poor tradeoff
Document the missing "all bands" limitation.
The PR objectives explicitly state this preset excludes the all-bands option because it "could not be made to work in Betaflight during testing." This caveat is absent from the DESCRIPTION fields, so users will not understand the preset is incomplete. Add a DESCRIPTION line noting this limitation.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@presets/4.3/vtx/Unify_Pro32_DP_SA2_1.txt` at line 12, The DESCRIPTION for the
Unify_Pro32_DP_SA2_1 preset is missing the explicit limitation that the
all-bands option was excluded because it could not be made to work in Betaflight
during testing. Update the DESCRIPTION entry in this preset file to add a clear
note about that limitation alongside the existing power and manufacturer notes,
so users can see that the preset is intentionally incomplete.
2 participants
Adds a preset for the TBS Unify Pro32 DP according to provided VTX table at https://www.team-blacksheep.com/media/files/vtx-table-for-betaflight.txt.
Doesn't currently include the "all bands" option - I wasn't able to get this working at all in Betaflight, but maybe I was doing something wrong?
Summary by CodeRabbit