Skip to content

sugark analog whoop osd - #576

Merged
limonspb merged 2 commits into
betaflight:masterfrom
sugaarK:osd
Apr 15, 2026
Merged

sugark analog whoop osd#576
limonspb merged 2 commits into
betaflight:masterfrom
sugaarK:osd

Conversation

@sugaarK

@sugaarK sugaarK commented Apr 15, 2026

Copy link
Copy Markdown
Member

analog osd settings for racing whoop

Screenshot 2026-04-15 at 3 27 51 pm

Summary by CodeRabbit

  • New Features
    • Added a new OSD preset configuration profile for firmware 2025.12, featuring customizable alarm thresholds and on-screen element positioning tailored for analog OSD displays.

analog osd settings for racing whoop
@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A new Betaflight preset file is added for the sugarK analog OSD profile under firmware version 2025.12, configuring OSD alarm thresholds and on-screen element positions including RSSI, link quality, timers, throttle, VTX channel, and telemetry display settings.

Changes

Cohort / File(s) Summary
New OSD Preset File
presets/2025.12/osd/sugark_analog_osd.txt
Added new OSD preset with alarm threshold configurations (RSSI, dBm, capacity, altitude) and positional placement settings for on-screen display elements including telemetry stats and metadata tags.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • haslinghuis
  • betaflight-admin
  • limonspb

Poem

🐰 A sugar-sweet preset hops into view,
With OSD alarms and positions so true,
Display elements dance across the screen,
The analog magic, a beautiful scene!
Configuration complete, the drone will know,
Which telemetry stats it should show!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required template sections like objective, motivation, and testing details, providing only a brief phrase and an image instead of comprehensive documentation. Add detailed sections covering what the preset does, why it was added, how it was tested, and any relevant issue references following the template structure.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding analog OSD settings for a sugark racing whoop, matching the file content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

upload correct photo
@github-actions

Copy link
Copy Markdown

@sugaarK

sugaarK commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
presets/2025.12/osd/sugark_analog_osd.txt (1)

5-5: Fix keyword typo in metadata.

SD in #$ KEYWORDS looks unintended; this should likely be OSD for discoverability consistency.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@presets/2025.12/osd/sugark_analog_osd.txt` at line 5, The metadata keywords
line '#$ KEYWORDS: analog, SD, whoop, OSD, sugarK, racing' contains a typo:
replace the incorrect token "SD" with "OSD" so the list reads '#$ KEYWORDS:
analog, OSD, whoop, OSD, sugarK, racing' (or remove the duplicate if you prefer
a unique set) to ensure discoverability and consistency with the file's OSD
context.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@presets/2025.12/osd/sugark_analog_osd.txt`:
- Line 5: The metadata keywords line '#$ KEYWORDS: analog, SD, whoop, OSD,
sugarK, racing' contains a typo: replace the incorrect token "SD" with "OSD" so
the list reads '#$ KEYWORDS: analog, OSD, whoop, OSD, sugarK, racing' (or remove
the duplicate if you prefer a unique set) to ensure discoverability and
consistency with the file's OSD context.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 356abf2d-406d-46c6-9121-60401bba311e

📥 Commits

Reviewing files that changed from the base of the PR and between 71872fd and fb90c1f.

📒 Files selected for processing (1)
  • presets/2025.12/osd/sugark_analog_osd.txt

@limonspb
limonspb merged commit 57de2b5 into betaflight:master Apr 15, 2026
3 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 30, 2026
@sugaarK
sugaarK deleted the osd branch May 2, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants