Skip to content

fix up some mistakes#578

Merged
limonspb merged 2 commits into
betaflight:masterfrom
sugaarK:fixs
Apr 30, 2026
Merged

fix up some mistakes#578
limonspb merged 2 commits into
betaflight:masterfrom
sugaarK:fixs

Conversation

@sugaarK

@sugaarK sugaarK commented Apr 30, 2026

Copy link
Copy Markdown
Member

changed all OSD presets to COMMUNITY, fixed crash flip mode on karate whoop, trying to fix osd images on my osd presets

Summary by CodeRabbit

Documentation

  • Updated preset description image reference

Chores

  • Reclassified multiple OSD presets from official to community status
  • Adjusted crash flip rate parameter in whoop tune preset

changed all OSD presets to COMMUNITY, fixed crash flip mode on karate whoop, trying to fix osd images on my osd presets
@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@sugaarK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 13 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 37e4e149-0b63-4ce9-9d54-d7882f4e5830

📥 Commits

Reviewing files that changed from the base of the PR and between 247c7ad and 4d82695.

📒 Files selected for processing (2)
  • presets/2025.12/osd/sugark_analog_osd.txt
  • presets/2025.12/osd/sugark_hdzero_osd.txt
📝 Walkthrough

Walkthrough

Five preset configuration files updated: three UAV_tech OSD presets transitioned from OFFICIAL to COMMUNITY status, one OSD preset's preview image URL refreshed, and one karate whoop tune parameter value adjusted from 20 to 30.

Changes

Cohort / File(s) Summary
UAV_tech Status Updates
presets/2025.12/osd/UAV_tech_Analog.txt, presets/2025.12/osd/UAV_tech_DJI.txt, presets/2025.12/osd/UAV_tech_DJI_GPS.txt
Changed #$ STATUS metadata field from OFFICIAL to COMMUNITY across three UAV_tech presets.
OSD Preview Image
presets/2025.12/osd/sugark_analog_osd.txt
Updated #$ DESCRIPTION preview image URL, replacing old GitHub user-attachments reference with private-user-images.githubusercontent.com URL and adjusted image dimensions.
Karate Whoop Tune Parameter
presets/2025.12/tune/karate/karate_whoop_2025_12.txt
Incremented crashflip_rate value from 20 to 30 in the "New crash flip mode" option.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • KarateBrot
  • haslinghuis
  • limonspb

Poem

🐰 Five presets hop in for a gentle refresh,
Status updates whisper, new images mesh,
Crashflip rates climbing, a tune takes flight,
Community voices, the defaults feel right!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description briefly lists the changes but lacks detail about why these changes are needed and fails to follow the repository template requirements. Expand the description with specific details about each change, explain the rationale, and follow the provided template structure for clarity.
Title check ❓ Inconclusive The title is vague and generic, using non-descriptive phrasing ('fix up some mistakes') that doesn't convey meaningful information about the actual changes. Provide a more specific title that highlights the main changes, such as 'Update OSD presets status to COMMUNITY and adjust karate whoop crash flip mode'.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 53 minutes and 13 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@presets/2025.12/osd/sugark_analog_osd.txt`:
- Line 18: The preset metadata contains an <img ... src="...jwt=..."> with a
signed JWT query parameter; remove the tokenized private URL from the image tag
in the preset (the src value inside the <img ...> on the DESCRIPTION line) and
replace it with a non-tokenized public URL or a local/relative image reference
(or remove the image entirely) so no jwt=... query param remains in the file.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b8651b1-edb0-4bf4-967c-3f8791edac18

📥 Commits

Reviewing files that changed from the base of the PR and between dca2ad3 and 247c7ad.

📒 Files selected for processing (5)
  • presets/2025.12/osd/UAV_tech_Analog.txt
  • presets/2025.12/osd/UAV_tech_DJI.txt
  • presets/2025.12/osd/UAV_tech_DJI_GPS.txt
  • presets/2025.12/osd/sugark_analog_osd.txt
  • presets/2025.12/tune/karate/karate_whoop_2025_12.txt

Comment thread presets/2025.12/osd/sugark_analog_osd.txt
@github-actions

Copy link
Copy Markdown

@limonspb limonspb merged commit e6f474f into betaflight:master Apr 30, 2026
3 checks passed
@sugaarK sugaarK deleted the fixs branch May 2, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants