Update basher preset from 4.5 to 2025.12#565
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new firmware-2025.12 preset tune file for “Basher 5" 6S by JazzMutant” with metadata, includes, simplified_tuning values, selectable option groups for DShot/protocols, tuning and filter profiles, applies simplified_tuning, and optionally imports recopter actual rates. ChangesBasher 5" 6S Preset
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 52 minutes and 24 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@presets/2025.12/tune/basher_jazzmutant_tune.txt`:
- Line 30: Update the DISCUSSION metadata line so it references the original PR
instead of the Telegram link: replace the current "#$ DISCUSSION:
https://t.me/basherframes" entry with a DISCUSSION entry that points to "PR
`#512`" (e.g., "#$ DISCUSSION: PR `#512`"), ensuring the "#$ DISCUSSION" token is
preserved and only the value is changed to maintain continuity with the original
preset introduction.
28d42aa to
cf3b558
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@presets/2025.12/tune/basher_jazzmutant_tune.txt`:
- Line 93: The Filters option group header is missing the EXCLUSIVE marker;
update the group declaration line "#$ OPTION_GROUP BEGIN: Filters (select one)"
to include the exclusive keyword so the parser enforces mutual exclusion (i.e.
change it to the format "#$ OPTION_GROUP BEGIN: (EXCLUSIVE) Filters (select
one)"), ensuring the group containing the "Normal builds" and "Clean builds"
options is treated as mutually exclusive.
- Line 43: The preset uses the wrong CLI parameter name; replace the incorrect
command simplified_d_max_gain with the correct Betaflight CLI parameter
d_max_gain in the preset (i.e., change the line containing "set
simplified_d_max_gain = 0" to use "set d_max_gain = 0"), making sure the rest of
the line formatting remains consistent with other "set" commands.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cf7447a9-70db-4ccd-a504-3153f8cb5cd4
📒 Files selected for processing (1)
presets/2025.12/tune/basher_jazzmutant_tune.txt
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@presets/2025.12/tune/basher_jazzmutant_tune.txt`:
- Line 25: Update the “Clean builds” note to remove awkward phrasing and make
the safety condition unambiguous: replace "Select 'Clean builds' filters option
only if your build is perfect and props are always not very damaged." with a
clearer sentence such as "Select the 'Clean builds' filter only when the build
is in excellent condition and props are minimally damaged," ensuring the phrase
references the "Clean builds" filter and the required condition is explicit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d5e89b6c-33ff-44e2-8be0-dd98f94844c9
📒 Files selected for processing (1)
presets/2025.12/tune/basher_jazzmutant_tune.txt
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
Preview URL: https://pr565.betaflight-firmware-presets.pages.dev |
|
@haslinghuis Can you please review this MR or tag someone else who can do it? |
Updated command for d max slider and updated references in include commands
Summary by CodeRabbit