Skip to content

Update basher preset from 4.5 to 2025.12#565

Open
Jaz7Mutant wants to merge 3 commits into
betaflight:masterfrom
Jaz7Mutant:jazzmutant-basher-2025.12
Open

Update basher preset from 4.5 to 2025.12#565
Jaz7Mutant wants to merge 3 commits into
betaflight:masterfrom
Jaz7Mutant:jazzmutant-basher-2025.12

Conversation

@Jaz7Mutant

@Jaz7Mutant Jaz7Mutant commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Updated command for d max slider and updated references in include commands

Summary by CodeRabbit

  • New Features
    • New firmware-specific tuning preset for Basher 5" 6S by JazzMutant (firmware 2025.12, EXPERIMENTAL) with updated PID, gyro/filter and dynamic notch settings.
    • Configurable options: DShot modes (DShot600 default / DShot300), bidirectional DShot, dynamic idle, thrust linearisation, optional battery sag compensation, and optional throttle boost disable.
    • Two tuning profiles: Normal (default) and Clean builds, plus matched rate (roll/pitch/yaw) settings applied.

@coderabbitai

coderabbitai Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Jaz7Mutant has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 24 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd259de7-ba88-4bd3-bed9-1628e5518027

📥 Commits

Reviewing files that changed from the base of the PR and between 3fbc179 and 7bcb95a.

📒 Files selected for processing (1)
  • presets/2025.12/tune/basher_jazzmutant_tune.txt
📝 Walkthrough

Walkthrough

Adds a new firmware-2025.12 preset tune file for “Basher 5" 6S by JazzMutant” with metadata, includes, simplified_tuning values, selectable option groups for DShot/protocols, tuning and filter profiles, applies simplified_tuning, and optionally imports recopter actual rates.

Changes

Basher 5" 6S Preset

Layer / File(s) Summary
Header / Metadata
presets/2025.12/tune/basher_jazzmutant_tune.txt
Adds preset header: title, firmware, category, status, keywords, author, parser, HTML description, discussion link, and FORCE_OPTIONS_REVIEW.
Base Includes
presets/.../warnings.txt, presets/.../tune_defaults.txt, presets/.../rpm_filter_defaults.txt
Includes shared warnings, tune defaults, and RPM/filter defaults.
Data Shape / Tuning Values
presets/2025.12/tune/basher_jazzmutant_tune.txt
Sets dshot_bidir=ON, core simplified_tuning gains and filtering, dynamic notch parameters, gyro_lpf2_static_hz=0, TPA (mode=D, rate=65, breakpoint=1650), anti-gravity gain, and PID sum limits.
Options — Protocols
presets/2025.12/tune/basher_jazzmutant_tune.txt
Adds exclusive DShot protocol options: DSHOT600 (default) and DSHOT300.
Options — Tuning Toggles
presets/2025.12/tune/basher_jazzmutant_tune.txt
Adds tuning options: dyn_idle_min_rpm=35, thrust_linear=20, optional vbat_sag_compensation=100, optional throttle_boost=0.
Options — Filter Profiles
presets/2025.12/tune/basher_jazzmutant_tune.txt
Adds mutually exclusive filter/profile options: “Normal builds” (default multipliers, dyn_notch_count=2, RPM filter settings) and “Clean builds” (alternate multipliers, dyn_notch_count=1, different RPM filter weights/Q and dterm_lpf1_dyn_expo=7).
Apply / Wiring
presets/2025.12/tune/basher_jazzmutant_tune.txt
Invokes simplified_tuning apply to materialise chosen tuning settings.
Optional Rates Include
presets/2025.12/tune/basher_jazzmutant_tune.txt, presets/2025.12/rates/defaults.txt
Provides optional include of recopter rates (rates_type=ACTUAL) and sets roll/pitch/yaw RC rate, expo, and srate values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • limonspb
  • haslinghuis
  • betaflight-admin

Poem

🐰
I tuned the springs and trimmed the air,
Basher hums steady with JazzMutant care,
Notches and filters in tidy array,
DShot sings loud and the props want to play,
Off it hops — swift, smooth, and fair.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is vague and incomplete. It mentions updating a 'd max slider' command and 'include commands' references, but the raw summary shows a comprehensive new preset with numerous features (DShot, TPA, filters, user options) that are not explained in the description. Provide a detailed description of all changes made, including the new features added (DShot bidir, TPA settings, filter profiles, user options) and how the preset differs from the previous 4.5 version.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change—updating the Basher preset from version 4.5 to 2025.12, which aligns with the raw summary showing a new firmware-specific preset for 2025.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 52 minutes and 24 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@presets/2025.12/tune/basher_jazzmutant_tune.txt`:
- Line 30: Update the DISCUSSION metadata line so it references the original PR
instead of the Telegram link: replace the current "#$ DISCUSSION:
https://t.me/basherframes" entry with a DISCUSSION entry that points to "PR
`#512`" (e.g., "#$ DISCUSSION: PR `#512`"), ensuring the "#$ DISCUSSION" token is
preserved and only the value is changed to maintain continuity with the original
preset introduction.

Comment thread presets/2025.12/tune/basher_jazzmutant_tune.txt
@Jaz7Mutant Jaz7Mutant force-pushed the jazzmutant-basher-2025.12 branch from 28d42aa to cf3b558 Compare May 3, 2026 09:09

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@presets/2025.12/tune/basher_jazzmutant_tune.txt`:
- Line 93: The Filters option group header is missing the EXCLUSIVE marker;
update the group declaration line "#$ OPTION_GROUP BEGIN: Filters (select one)"
to include the exclusive keyword so the parser enforces mutual exclusion (i.e.
change it to the format "#$ OPTION_GROUP BEGIN: (EXCLUSIVE) Filters (select
one)"), ensuring the group containing the "Normal builds" and "Clean builds"
options is treated as mutually exclusive.
- Line 43: The preset uses the wrong CLI parameter name; replace the incorrect
command simplified_d_max_gain with the correct Betaflight CLI parameter
d_max_gain in the preset (i.e., change the line containing "set
simplified_d_max_gain = 0" to use "set d_max_gain = 0"), making sure the rest of
the line formatting remains consistent with other "set" commands.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cf7447a9-70db-4ccd-a504-3153f8cb5cd4

📥 Commits

Reviewing files that changed from the base of the PR and between 28d42aa and cf3b558.

📒 Files selected for processing (1)
  • presets/2025.12/tune/basher_jazzmutant_tune.txt

Comment thread presets/2025.12/tune/basher_jazzmutant_tune.txt
Comment thread presets/2025.12/tune/basher_jazzmutant_tune.txt Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@presets/2025.12/tune/basher_jazzmutant_tune.txt`:
- Line 25: Update the “Clean builds” note to remove awkward phrasing and make
the safety condition unambiguous: replace "Select 'Clean builds' filters option
only if your build is perfect and props are always not very damaged." with a
clearer sentence such as "Select the 'Clean builds' filter only when the build
is in excellent condition and props are minimally damaged," ensuring the phrase
references the "Clean builds" filter and the required condition is explicit.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d5e89b6c-33ff-44e2-8be0-dd98f94844c9

📥 Commits

Reviewing files that changed from the base of the PR and between cf3b558 and 3fbc179.

📒 Files selected for processing (1)
  • presets/2025.12/tune/basher_jazzmutant_tune.txt

Comment thread presets/2025.12/tune/basher_jazzmutant_tune.txt Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

@Jaz7Mutant

Copy link
Copy Markdown
Contributor Author

@haslinghuis Can you please review this MR or tag someone else who can do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant