yy3588: fix eDP video port and timing, document panel requirement#508
Conversation
eDP on VP1 fails: VP1 shares its PLL with VP0 so the 141.5MHz dclk gets clamped to 132MHz and the VOP2 port mux times out on the second modeset. Move eDP to VP2 as the vendor does and hand DP VP1 instead. Use the BOE QV116FHB-N81 datasheet typical timing and drop the panel enable GPIO, GPIO0_C4 is already held high by the always-on wifi_disable regulator in the board DTS. Signed-off-by: SuperKali <hello@superkali.me>
…lays With the vendor kernel the display-subsystem bind stalls at boot when a display overlay is enabled without its panel attached, on eDP the forced HPD keeps link training against a missing sink. State the constraint in the overlay descriptions. Signed-off-by: SuperKali <hello@superkali.me>
4e30945 to
0e45a19
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Disabled knowledge base sources:
WalkthroughThis change updates metadata descriptions in the Youyeetoo YY3588 DSI0, DSI1, and eDP device tree overlays to document panel connection requirements and boot-stall avoidance guidance. The eDP overlay additionally adds panel-timing documentation comments and reroutes video processor connections, switching edp1_in_vp2 to enabled, changing fragment@7's connect target from vp1_out_edp1 to vp2_out_edp1, and adding fragments to disable dp0_in_vp2 while enabling dp0_in_vp1. Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Follow-up to #507 after testing the eDP kit on YY3588 hardware.
eDP on VP1 does not work in practice: VP1 shares its PLL with VP0, the 141.5MHz dclk gets clamped to 132MHz and the VOP2 port mux times out on the second modeset, so the screen dies right after the boot logo. eDP now runs on VP2 like the vendor tree and DP moves to VP1. The panel timing follows the BOE QV116FHB-N81 datasheet typical, and the panel enable GPIO is dropped since GPIO0_C4 already belongs to the always-on wifi_disable regulator in the board DTS.
The overlay descriptions now warn that a display overlay must not be enabled without its panel attached: with the vendor kernel the display-subsystem bind stalls at boot, on eDP because force-hpd keeps training against a missing sink.
Tested on YY3588: dsi1 kit working with display and GT911 touch, eDP verified up to a stable 1920x1080p60 link (the sample kit here has an analog defect, so panel-side validation is partial).