youyeetoo: fix 7" touch with TPC2059 config, add YY3588 display overlays#507
Merged
SuperKali merged 5 commits intoJul 5, 2026
Merged
Conversation
The 7" 1024x600 DSI kit on Youyeetoo R1 and YY3588 is a TPC2059 panel whose GT911 needs the vendor cfg blob, and the 11.6" eDP kit ships a GT928 wired portrait. Add both blobs from the youyeetoo yy3588_linux tree as new tp-size cases 2059 and 928 so existing boards keep their current behavior. Signed-off-by: SuperKali <hello@superkali.me>
Vendor evb7-v11 wires HDMI-RX hotplug detect on GPIO1_D5, not GPIO1_C6. GPIO1_C6 is the pwm15m2 pad used by the eDP kit backlight, so keeping detect there breaks the eDP overlay pinmux. Signed-off-by: SuperKali <hello@superkali.me>
tp-size 911 programs the WGJ89006B 4096x4096 blob, which does not match the 7" TPC2059 sensor matrix and leaves dead zones at the panel edges. Switch both DSI overlays to the new 2059 case that sends the vendor 1024x600 blob with 1:1 coordinates. Signed-off-by: SuperKali <hello@superkali.me>
…lays Wire the three official Youyeetoo display kits from the vendor rk3588-lcd-yyt.dtsi: 7" 1024x600 TPC2059 panels on dsi0 and dsi1 and the 11.6" 1920x1080 eDP panel with GT928 touch. The previous dsi1 overlay described a non-existent Innolux panel. eDP runs on VP1 because dp0 already owns VP2 on this board. Signed-off-by: SuperKali <hello@superkali.me>
The 7" kit backlight driver is active-low: with normal polarity raising brightness dims the panel, confirmed on R1 hardware. The vendor Android DTB programs the same PWM inverted. Flip polarity on all four DSI overlays; the eDP backlight stays normal per vendor. Signed-off-by: SuperKali <hello@superkali.me>
WalkthroughThis PR adds three new Rockchip device tree overlays (DSI0, DSI1 rework, eDP) for the Youyeetoo YY3588 board, each configuring backlight, regulator, PWM, display panel timings, DSI/eDP routing, and a GT9xx-family touchscreen. Existing Youyeetoo R1 overlays get updated PWM and touch-size values. The GT9xx touchscreen driver gains new panel flags (bgt2059, bgt928) and configuration data arrays with corresponding raw config payload files. The YY3588 board DTS changes the HDMI RX hotplug detect GPIO, and the overlay Makefile is updated to build the new DTBOs. Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
drivers/input/touchscreen/gt9xx/gt9xx_cfg.h (1)
70-79: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove the orphaned
2059-V1-1024X600.cfgfile. It isn’t referenced anywhere in the tree, so it can be dropped unless it’s meant to be wired into one of the GT9xx config arrays.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@drivers/input/touchscreen/gt9xx/gt9xx_cfg.h` around lines 70 - 79, Remove the unused 2059-V1-1024X600.cfg asset from the tree since it is not referenced by any GT9xx configuration path. Verify the GT9xx config arrays in gt9xx_cfg.h, especially gtp_dat_tpc2059 and gtp_dat_gt928, still include the intended config files and that no code or build references remain to the orphaned file before deleting it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@drivers/input/touchscreen/gt9xx/gt9xx_cfg.h`:
- Around line 70-79: Remove the unused 2059-V1-1024X600.cfg asset from the tree
since it is not referenced by any GT9xx configuration path. Verify the GT9xx
config arrays in gt9xx_cfg.h, especially gtp_dat_tpc2059 and gtp_dat_gt928,
still include the intended config files and that no code or build references
remain to the orphaned file before deleting it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c8db502f-95ae-4859-9d93-cf6644d13409
📒 Files selected for processing (12)
arch/arm64/boot/dts/rockchip/overlay/Makefilearch/arm64/boot/dts/rockchip/overlay/youyeetoo-r1-display-dsi0.dtsarch/arm64/boot/dts/rockchip/overlay/youyeetoo-r1-display-dsi1.dtsarch/arm64/boot/dts/rockchip/overlay/youyeetoo-yy3588-display-dsi0.dtsarch/arm64/boot/dts/rockchip/overlay/youyeetoo-yy3588-display-dsi1.dtsarch/arm64/boot/dts/rockchip/overlay/youyeetoo-yy3588-display-edp.dtsarch/arm64/boot/dts/rockchip/rk3588-youyeetoo-yy3588.dtsdrivers/input/touchscreen/gt9xx/2059-V1-1024X600.cfgdrivers/input/touchscreen/gt9xx/GT928_Config_20190318_111541.cfgdrivers/input/touchscreen/gt9xx/TPC2059-7.0-Config_20241122_143209.cfgdrivers/input/touchscreen/gt9xx/gt9xx.cdrivers/input/touchscreen/gt9xx/gt9xx_cfg.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 7" 1024x600 DSI kit shared by the R1 and the YY3588 is a TPC2059 panel. Its GT911 was programmed with the WGJ89006B 4096x4096 blob (tp-size 911), which does not match the sensor matrix and leaves dead zones at the panel edges. The vendor yy3588_linux tree carries the right cfg blob, imported here as new tp-size 2059, together with the GT928 blob for the 11.6" eDP kit (tp-size 928). Existing tp-size cases are untouched.
The YY3588 gains overlays for its three display kits (dsi0, dsi1, edp), wired from the vendor DTB and rk3588-lcd-yyt.dtsi. The old dsi1 overlay described a panel this board never shipped with. eDP runs on VP1 since dp0 already owns VP2, and hdmirx-det moves to GPIO1_D5 to match the vendor schematic and free the eDP backlight PWM pad.
The 7" kit backlight is active-low: with normal PWM polarity raising brightness dims the panel. All four DSI overlays now program it inverted, same as the vendor Android DTB.
Tested on R1 hardware with the dsi0 kit: touch reports 0-1024/0-600 with no edge dead zones, multi-touch and drawing work, brightness scale is correct. The YY3588 kits and the eDP path still need board testing.