Skip to content

Removed unused vars and imports in ripper #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashraj0902 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed unused vars and imports in ripper #2178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/BatoRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ public List<String> getURLsFromPage(Document doc) {
logger.info("Script data: " + s);

Pattern p = Pattern.compile(".*imgHttps = (\\[\"[^\\];]*\"\\]);.*");
Matcher m = p.matcher(s);
String json = scanForImageList(p, s);

logger.info("JSON: " + json);
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/com/rarchives/ripme/ripper/rippers/BooruRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
import com.rarchives.ripme.utils.Utils;
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URL;
import java.util.ArrayList;
import java.util.List;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/ErofusRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ public List<String> getURLsFromPage(Document page) {
logger.info("Retrieving " + subUrl);
sendUpdate(RipStatusMessage.STATUS.LOADING_RESOURCE, subUrl);
Document subPage = Http.url(subUrl).get();
List<String> subalbumImages = getURLsFromPage(subPage);
} catch (IOException e) {
logger.warn("Error while loading subalbum " + subUrl, e);
}
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/MyhentaigalleryRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.rarchives.ripme.ripper.rippers;

import com.rarchives.ripme.ripper.AbstractHTMLRipper;
import com.rarchives.ripme.utils.Http;
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URL;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/MyreadingmangaRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
package com.rarchives.ripme.ripper.rippers;

import com.rarchives.ripme.ripper.AbstractHTMLRipper;
import com.rarchives.ripme.utils.Http;
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URL;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/RedditRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public RedditRipper(URL url) throws IOException {
super(url);
}

private static final String HOST = "reddit";
private static final String HOST = "reddit";
private static final String DOMAIN = "reddit.com";

private static final String REDDIT_USER_AGENT = "RipMe:github.com/RipMeApp/ripme:" + UpdateUtils.getThisJarVersion() + " (by /u/metaprime and /u/ineedmorealts)";
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/RulePornRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import com.rarchives.ripme.ripper.AbstractSingleFileRipper;
import org.jsoup.nodes.Document;

import com.rarchives.ripme.utils.Http;

public class RulePornRipper extends AbstractSingleFileRipper {

Expand Down
3 changes: 1 addition & 2 deletions src/main/java/com/rarchives/ripme/ripper/rippers/SmuttyRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@

public class SmuttyRipper extends AbstractHTMLRipper {

private static final String DOMAIN = "smutty.com",
HOST = "smutty";
private static final String DOMAIN = "smutty.com";

public SmuttyRipper(URL url) throws IOException {
super(url);
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/SoundgasmRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

public class SoundgasmRipper extends AbstractHTMLRipper {

private static final String HOST = "soundgasm.net";

public SoundgasmRipper(URL url) throws IOException, URISyntaxException {
super(new URI(url.toExternalForm()).toURL());
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/ripper/rippers/TeenplanetRipper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import org.jsoup.nodes.Document;
import org.jsoup.nodes.Element;

import com.rarchives.ripme.utils.Http;
import com.rarchives.ripme.utils.Utils;

public class TeenplanetRipper extends AbstractHTMLRipper {
Expand Down
4 changes: 0 additions & 4 deletions src/main/java/com/rarchives/ripme/ui/ContextMenuMouseListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,8 @@
import com.rarchives.ripme.uiUtils.ContextActionProtections;

import java.awt.Toolkit;
import java.awt.datatransfer.Clipboard;
import java.awt.datatransfer.DataFlavor;
import java.awt.datatransfer.Transferable;
import java.awt.datatransfer.UnsupportedFlavorException;
import java.awt.event.*;
import java.io.IOException;

import javax.swing.*;
import javax.swing.text.JTextComponent;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/rarchives/ripme/uiUtils/ContextActionProtections.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.rarchives.ripme.uiUtils;

import javax.swing.*;
import javax.swing.text.JTextComponent;
import java.awt.*;
import java.awt.datatransfer.Clipboard;
Expand Down
6 changes: 1 addition & 5 deletions src/test/java/com/rarchives/ripme/tst/ripper/rippers/DeviantartRipperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
import java.util.List;

import com.rarchives.ripme.ripper.rippers.DeviantartRipper;
import com.rarchives.ripme.utils.Http;
import org.jsoup.nodes.Document;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -49,9 +48,6 @@ public void testGetGID() throws IOException, URISyntaxException {
@Test
@Disabled("Broken ripper")
public void testGetGalleryIDAndUsername() throws IOException, URISyntaxException {
URL url = new URI("https://www.deviantart.com/airgee/gallery/").toURL();
DeviantartRipper ripper = new DeviantartRipper(url);
Document doc = Http.url(url).get();

@metaprime metaprime Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of deleting the body of the test, fix the test to use the unused variables

// Had to comment because of refactoring/style change
// assertEquals("airgee", ripper.getUsername(doc));
// assertEquals("714589", ripper.getGalleryID(doc));
Expand Down
1 change: 0 additions & 1 deletion src/test/java/com/rarchives/ripme/tst/ripper/rippers/FlickrRipperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import com.rarchives.ripme.ripper.rippers.FlickrRipper;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

Expand Down
4 changes: 0 additions & 4 deletions src/test/java/com/rarchives/ripme/tst/ripper/rippers/JabArchivesRipperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
package com.rarchives.ripme.tst.ripper.rippers;

import java.io.IOException;
import java.net.URL;

import com.rarchives.ripme.ripper.rippers.JabArchivesRipper;

@metaprime metaprime Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see this is a stub of a test file that hasn't been implemented yet. I'd rather see someone add an implementation rather than remove parts of the stub.


public class JabArchivesRipperTest extends RippersTest {
// TODO add a test
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/com/rarchives/ripme/tst/ripper/rippers/RedditRipperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ public void testRedditGfyBadURL() throws IOException, URISyntaxException {
*/
@Test
public void testRedditGfycatRedirectURL() throws IOException, URISyntaxException {
RedditRipper ripper = new RedditRipper(
new URI("https://www.reddit.com/r/NSFW_GIF/comments/ennwsa/gorgeous_tits/").toURL());

@metaprime metaprime Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test may appear to test nothing but really is expecting that API call to complete without throwing. Update the test to fix it accordingly instead of removing the body of the test.

}

@Test
Expand Down
1 change: 0 additions & 1 deletion src/test/java/com/rarchives/ripme/tst/ripper/rippers/SoundgasmRipperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URL;

public class SoundgasmRipperTest extends RippersTest {

Expand Down
4 changes: 0 additions & 4 deletions src/test/java/com/rarchives/ripme/tst/ripper/rippers/VideoRippersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ private void videoTestHelper(VideoRipper ripper) {
public void testTwitchVideoRipper() throws IOException, URISyntaxException {
List<URL> contentURLs = new ArrayList<>();
contentURLs.add(new URI("https://clips.twitch.tv/FaithfulIncredulousPotTBCheesePull").toURL());
for (URL url : contentURLs) {
// TwitchVideoRipper ripper = new TwitchVideoRipper(url);
// videoTestHelper(ripper);
}

@metaprime metaprime Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The better fix here is to uncomment the loop body and disable the test (mark flaky, see other disabled tests that have done so)

}

@Test
Expand Down