Removed unused vars and imports in ripper#2178
Open
yashraj0902 wants to merge 1 commit into
Open
Conversation
metaprime
reviewed
Jun 3, 2026
| public void testGetGalleryIDAndUsername() throws IOException, URISyntaxException { | ||
| URL url = new URI("https://www.deviantart.com/airgee/gallery/").toURL(); | ||
| DeviantartRipper ripper = new DeviantartRipper(url); | ||
| Document doc = Http.url(url).get(); |
Contributor
There was a problem hiding this comment.
instead of deleting the body of the test, fix the test to use the unused variables
metaprime
reviewed
Jun 3, 2026
| import java.io.IOException; | ||
| import java.net.URL; | ||
|
|
||
| import com.rarchives.ripme.ripper.rippers.JabArchivesRipper; |
Contributor
There was a problem hiding this comment.
As you can see this is a stub of a test file that hasn't been implemented yet. I'd rather see someone add an implementation rather than remove parts of the stub.
metaprime
reviewed
Jun 3, 2026
| public void testRedditGfycatRedirectURL() throws IOException, URISyntaxException { | ||
| RedditRipper ripper = new RedditRipper( | ||
| new URI("https://www.reddit.com/r/NSFW_GIF/comments/ennwsa/gorgeous_tits/").toURL()); | ||
|
|
Contributor
There was a problem hiding this comment.
This test may appear to test nothing but really is expecting that API call to complete without throwing. Update the test to fix it accordingly instead of removing the body of the test.
metaprime
reviewed
Jun 3, 2026
| for (URL url : contentURLs) { | ||
| // TwitchVideoRipper ripper = new TwitchVideoRipper(url); | ||
| // videoTestHelper(ripper); | ||
| } |
Contributor
There was a problem hiding this comment.
The better fix here is to uncomment the loop body and disable the test (mark flaky, see other disabled tests that have done so)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused local variables and imports identified by the IDE.
These changes do not affect functionality and are intended to improve code cleanliness and readability.